Skip to content

fix: fix tests #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 4 commits into from
Oct 1, 2025
Merged

fix: fix tests #1389

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c6dfbe
setting otel span status as error on langfuse error
Oct 1, 2025
3502960
remove unused imports and move imports to top of the file
Oct 1, 2025
2ccee12
fix tests
Oct 1, 2025
35b5abe
Merge branch 'otel-status-for-error-spans' into error_otel_status
hassiebp Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions langfuse/_client/span.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,8 +559,7 @@ def _set_otel_span_status_if_error(
if level == "ERROR" and self._otel_span.is_recording():
try:
self._otel_span.set_status(
status=Status(StatusCode.ERROR),
description=status_message
Status(StatusCode.ERROR, description=status_message)
)
except Exception:
# Silently ignore any errors when setting OTEL status to avoid existing flow disruptions
Expand Down