Repository navigation
refactor: drop the CompactionOptions cast - #5305
Open
jonasdedden wants to merge 1 commit into
Open
jonasdedden wants to merge 1 commit into
jonasdedden wants to merge 1 commit into
Conversation
pylance 12 declares `CompactionOptions` as `TypedDict(total=False)`, so an empty dict and partial `CompactionOptions(...)` literals type-check without casting. Remove the cast in `compact_files` and the test-only `_compaction_options` helper.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
|
@jiaoew1991 @yanghua some small simplification PR #5304 and #5303 also remove way more effectively dead code, they are a bit harder to review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 3/3 of splitting up #5301. pylance 12 declares
CompactionOptionsasTypedDict(total=False). An empty dict and partialCompactionOptions(...)literals now type-check, so the cast incompact_filesand the test-only_compaction_optionscast helper are no longer needed.No behavior change.
pyproject.tomlanduv.lockare untouched.Testing
uv run mypy(strict),ruff check,ruff format --check: cleanpytest tests/test_distributed_compaction.py: 14 passed