feat: implement eth_getTransactionCount endpoint

.github/workflows/hive.yaml

@@ -22,7 +22,7 @@ jobs:
       matrix:
         include:
           - simulation: rpc-compat
-            run_command: just run-hive ethereum/rpc-compat "/eth_chainId|eth_getTransactionByBlockHashAndIndex|eth_getTransactionByBlockNumberAndIndex|eth_getCode|eth_getStorageAt|eth_call|eth_getTransactionByHash|eth_getBlockByHash|eth_getBlockByNumber|eth_createAccessList|eth_getBlockTransactionCountByNumber|eth_getBlockTransactionCountByHash|eth_getBlockReceipts|eth_getTransactionReceipt|eth_blobGasPrice|eth_blockNumber"
+            run_command: just run-hive ethereum/rpc-compat "/eth_chainId|eth_getTransactionByBlockHashAndIndex|eth_getTransactionByBlockNumberAndIndex|eth_getCode|eth_getStorageAt|eth_call|eth_getTransactionByHash|eth_getBlockByHash|eth_getBlockByNumber|eth_createAccessList|eth_getBlockTransactionCountByNumber|eth_getBlockTransactionCountByHash|eth_getBlockReceipts|eth_getTransactionReceipt|eth_blobGasPrice|eth_blockNumber|ethGetTransactionCount"
     steps:
       - name: Checkout sources
         uses: actions/checkout@v3

README.md

@@ -81,13 +81,9 @@ kurtosis enclave stop lambdanet ; kurtosis enclave rm lambdanet
 Add support to follow a post-Merge localnet as a read-only RPC Node. This first milestone will only support a canonical chain (every incoming block has to be the child of the current head). 
 
 RPC endpoints
-- `debug_getRawBlock`
-- `debug_getRawHeader`
-- `debug_getRawReceipts`
-- `debug_getRawTransaction`
 - `engine_newPayloadV3` (excl. block building) ✅
-- `eth_blobBaseFee`
-- `eth_blockNumber` ✅
+- `eth_blobBaseFee` ✅
+- `eth_blockNumber` ✅ 
 - `eth_call` (at head block) ✅
 - `eth_chainId` ✅
 - `eth_createAccessList` (at head block) ✅
@@ -103,7 +99,7 @@ RPC endpoints
 - `eth_getTransactionByBlockHashAndIndex` ✅
 - `eth_getTransactionByBlockNumberAndIndex` ✅
 - `eth_getTransactionByHash` ✅
-- `eth_getTransactionCount`
+- `eth_getTransactionCount` ✅
 
 See issues and progress: https://github.com/lambdaclass/ethereum_rust/milestone/1
 

crates/rpc/eth/account.rs

@@ -65,6 +65,11 @@ pub struct GetStorageAtRequest {
     pub block: BlockIdentifierOrHash,
 }
 
+pub struct GetTransactionCountRequest {
+    pub address: Address,
+    pub block: BlockIdentifierOrHash,
+}
+
 impl RpcHandler for GetBalanceRequest {
     fn parse(params: &Option<Vec<Value>>) -> Option<GetBalanceRequest> {
         let params = params.as_ref()?;
@@ -158,6 +163,37 @@ impl RpcHandler for GetStorageAtRequest {
     }
 }
 
+impl RpcHandler for GetTransactionCountRequest {
+    fn parse(params: &Option<Vec<Value>>) -> Option<GetTransactionCountRequest> {
+        let params = params.as_ref()?;
+        if params.len() != 2 {
+            return None;
+        };
+        Some(GetTransactionCountRequest {
+            address: serde_json::from_value(params[0].clone()).ok()?,
+            block: serde_json::from_value(params[1].clone()).ok()?,
+        })
+    }
+    fn handle(&self, storage: Store) -> Result<Value, RpcErr> {
+        info!(
+            "Requested nonce of account {} at block {}",
+            self.address, self.block
+        );
+
+        // TODO: implement historical querying
+        let is_latest = self.block.is_latest(&storage)?;
+        if !is_latest {
+            return Err(RpcErr::Internal);
+        }
+
+        let nonce = storage
+            .get_nonce_by_account_address(self.address)?
+            .unwrap_or_default();
+
+        serde_json::to_value(format!("0x{:x}", nonce)).map_err(|_| RpcErr::Internal)
+    }
+}
+
 impl Display for BlockIdentifierOrHash {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {

crates/rpc/rpc.rs

@@ -13,7 +13,7 @@ use engine::{
     ExchangeCapabilitiesRequest,
 };
 use eth::{
-    account::{GetBalanceRequest, GetCodeRequest, GetStorageAtRequest},
+    account::{GetBalanceRequest, GetCodeRequest, GetStorageAtRequest, GetTransactionCountRequest},
     block::{
         self, GetBlockByHashRequest, GetBlockByNumberRequest, GetBlockReceiptsRequest,
         GetBlockTransactionCountRequest,
@@ -179,6 +179,7 @@ pub fn map_eth_requests(req: &RpcRequest, storage: Store) -> Result<Value, RpcEr
         "eth_blockNumber" => block::block_number(storage),
         "eth_call" => CallRequest::call(req, storage),
         "eth_blobBaseFee" => block::get_blob_base_fee(&storage),
+        "eth_getTransactionCount" => GetTransactionCountRequest::call(req, storage),
         _ => Err(RpcErr::MethodNotFound),
     }
 }

crates/storage/engines/api.rs

@@ -104,6 +104,14 @@ pub trait StoreEngine: Debug + Send {
         self.get_account_code(code_hash)
     }
 
+    /// Obtain account nonce via account address
+    fn get_nonce_by_account_address(&self, address: Address) -> Result<Option<u64>, StoreError> {
+        let nonce = self
+            .get_account_info(address)?
+            .map(|acc_info| acc_info.nonce);
+        Ok(nonce)
+    }
+
     fn get_transaction_by_hash(
         &self,
         transaction_hash: H256,

crates/storage/storage.rs

@@ -202,6 +202,16 @@ impl Store {
             .unwrap()
             .get_code_by_account_address(address)
     }
+    pub fn get_nonce_by_account_address(
+        &self,
+        address: Address,
+    ) -> Result<Option<u64>, StoreError> {
+        self.engine
+            .clone()
+            .lock()
+            .unwrap()
+            .get_nonce_by_account_address(address)
+    }
 
     pub fn add_account(&self, address: Address, account: Account) -> Result<(), StoreError> {
         self.engine.lock().unwrap().add_account(address, account)