Skip to content

Dissallow unwraps on L1 crates #2879

Description

@mpaulucci

Currently, only the prover dissallows unwraps, see:

[lints.clippy]
unwrap_used = "deny"

Unwraps in tests are still allowed:

allow-unwrap-in-tests = true

We should add this rule to L1 crates one by one and remove unwraps. Ideally we should change it for Errors, but if the error is unrecoverable we should at least use expect.

This ticket should be tackled in many PRs, even more than one PR per crate potentially. At the end, the rules to forbid unwraps should be enforced.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions