Repository navigation
feat(xla): admit image requests in CLI and continuous-batch serving - #895
Conversation
- own bounded LLaVA preprocessing in XLA workers - preserve logical usage while submitting prepared embeddings - route CLI images through the shared session contract Refs #861
ef9e081 to
18d6d0d
Compare
|
Rebased this PR onto There was one content conflict in
I also audited the automatically merged |
|
Post-rebase validation evidence:
|
Preserve declared media counts through the HTTP and worker boundaries so invalid images, audio, or video cannot silently fall back to text on OpenXLA. Enforce decoded image cardinality, output-option parity, qualified capability reporting, and text-only router rejection. Add deterministic preprocessing, cancellation, slot-reuse, capability, loader, accounting, and media-resolution regressions. Refs #861
|
Implemented the review hardening in Correctness changes
Regression coverage
Validation
The repository-wide |
Require every CLI image path to produce one decoded image before prepared prefill, while retaining the shared tolerant decoder and admission limits. Cover mixed valid and malformed multi-image input with a fail-closed regression. Refs #861
|
Addressed the final CLI cardinality review finding in
Validation:
The prior head |
…ablup#895) * feat(xla): admit image prefill in CLI and serving - own bounded LLaVA preprocessing in XLA workers - preserve logical usage while submitting prepared embeddings - route CLI images through the shared session contract Refs lablup#861 * fix(xla): harden multimodal request admission Preserve declared media counts through the HTTP and worker boundaries so invalid images, audio, or video cannot silently fall back to text on OpenXLA. Enforce decoded image cardinality, output-option parity, qualified capability reporting, and text-only router rejection. Add deterministic preprocessing, cancellation, slot-reuse, capability, loader, accounting, and media-resolution regressions. Refs lablup#861 * fix(xla): reject partial CLI image decode Require every CLI image path to produce one decoded image before prepared prefill, while retaining the shared tolerant decoder and admission limits. Cover mixed valid and malformed multi-image input with a fail-closed regression. Refs lablup#861
Summary
language_model.*checkpoint weights required by the real LLaVA Interleave targetValidation
cargo fmt --all -- --checkcargo clippy -p mlxcel --lib --tests --features xla-iree -- -D warningscargo check -p mlxcel --lib --tests --features xla-backendcargo check -p mlxcel --lib --tests --features xla-ireellava-interleave-qwen-0.5b-bf16: generated one token successfullyThe,finish_reason=length, usage24/1/25,[DONE]; subsequent/healthreturnedstatus=okThe full 4,583-test
xla-backendlibrary run progressed through the affected tests, including the updated XLA scaffold regression, but the process aborted at the existing CUDA-onlymodels::bitnet::tests::bitlinear_matmul_known_ternary_casebecause this host has no CUDA backend.Closes #861