Repository navigation
deps(deps): bump the minor-and-patch group across 1 directory with 11 updates - #828
Merged
Merged
Conversation
… updates Bumps the minor-and-patch group with 10 updates in the / directory: | Package | From | To | | --- | --- | --- | | [serde](https://github.com/serde-rs/serde) | `1.0.228` | `1.0.229` | | [anyhow](https://github.com/dtolnay/anyhow) | `1.0.103` | `1.0.104` | | [thiserror](https://github.com/dtolnay/thiserror) | `2.0.18` | `2.0.19` | | [clap](https://github.com/clap-rs/clap) | `4.6.1` | `4.6.2` | | [tokio](https://github.com/tokio-rs/tokio) | `1.52.3` | `1.53.0` | | [futures](https://github.com/rust-lang/futures-rs) | `0.3.32` | `0.3.33` | | [uuid](https://github.com/uuid-rs/uuid) | `1.23.5` | `1.24.0` | | [cxx](https://github.com/dtolnay/cxx) | `1.0.197` | `1.0.198` | | [globset](https://github.com/BurntSushi/ripgrep) | `0.4.18` | `0.4.19` | | [cc](https://github.com/rust-lang/cc-rs) | `1.2.67` | `1.3.0` | Updates `serde` from 1.0.228 to 1.0.229 - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.228...v1.0.229) Updates `anyhow` from 1.0.103 to 1.0.104 - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.103...1.0.104) Updates `thiserror` from 2.0.18 to 2.0.19 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@2.0.18...2.0.19) Updates `clap` from 4.6.1 to 4.6.2 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.6.1...clap_complete-v4.6.2) Updates `tokio` from 1.52.3 to 1.53.0 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.52.3...tokio-1.53.0) Updates `futures` from 0.3.32 to 0.3.33 - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.32...0.3.33) Updates `uuid` from 1.23.5 to 1.24.0 - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](uuid-rs/uuid@v1.23.5...v1.24.0) Updates `cxx` from 1.0.197 to 1.0.198 - [Release notes](https://github.com/dtolnay/cxx/releases) - [Commits](dtolnay/cxx@1.0.197...1.0.198) Updates `cxx-build` from 1.0.197 to 1.0.198 - [Release notes](https://github.com/dtolnay/cxx/releases) - [Commits](dtolnay/cxx@1.0.197...1.0.198) Updates `globset` from 0.4.18 to 0.4.19 - [Release notes](https://github.com/BurntSushi/ripgrep/releases) - [Changelog](https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md) - [Commits](BurntSushi/ripgrep@globset-0.4.18...globset-0.4.19) Updates `cc` from 1.2.67 to 1.3.0 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.2.67...cc-v1.3.0) --- updated-dependencies: - dependency-name: anyhow dependency-version: 1.0.104 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: cc dependency-version: 1.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: clap dependency-version: 4.6.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: cxx dependency-version: 1.0.198 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: cxx-build dependency-version: 1.0.198 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: futures dependency-version: 0.3.33 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: globset dependency-version: 0.4.19 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: serde dependency-version: 1.0.229 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: thiserror dependency-version: 2.0.19 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: tokio dependency-version: 1.53.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: uuid dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/cargo/minor-and-patch-cd34b036a0
branch
from
July 20, 2026 05:11
066c1b2 to
22b0b9c
Compare
This was referenced Aug 2, 2026
inureyes
added a commit
that referenced
this pull request
Aug 2, 2026
) * fix(tests): honor CARGO_TARGET_DIR and clap's singular alias label The nightly `make verify` job has been red on `main` because of two independent defects in the integration test suite, both surfacing in `tests/cli_help_consistency.rs`. `repo_binary_path` in `tests/common/mod.rs` reconstructed the binary location as `CARGO_MANIFEST_DIR/target/<profile>/<name>`, which is wrong whenever `CARGO_TARGET_DIR` is set. Both `nightly-verify.yml` and `release.yml` set it to `$HOME/.cargo-target/mlxcel` so the self-hosted runner keeps a warm build cache outside the checkout, so cargo built the binaries there while the tests looked for them in the workspace. Every test in the file failed on CI with `No such file or directory` while passing locally, and the helper is shared by 12 other integration test files. It now prefers the compile-time `CARGO_BIN_EXE_<name>` path cargo hands every integration test target, which already accounts for the profile, the target triple, and `CARGO_TARGET_DIR`, then falls back to a `current_exe()`-derived profile directory for binaries it does not name by hand, then to the previous reconstruction. The existing `if !binary.exists()` skip guards in the real-model tests keep working because the helper still returns a path unconditionally; the new `binary_resolution_report` lists every candidate and whether it exists, and the two spawn sites in the help test fold it into their panic so the next occurrence is diagnosable from the panic alone. `drafter_flag_aliases_are_documented_on_both_binaries` asserted on the literal `[aliases: X]`. `clap_builder` 4.6.2 introduced a `pluralize` call in its help template that renders `[alias: X]` for exactly one visible alias, and each of the four flags carries exactly one, so all four assertions broke on a dependency bump (`3ccb693a3`, #828) rather than a code change. All four aliases are still declared and still documented, so the fix belongs in the assertion, not in the CLI. It now locates the flag's own help entry, parses the alias names out of whatever alias annotation clap rendered, and matches on the name. Accepting either label keeps the assertion working across clap's singular/plural rendering and across a future second alias; scoping it to one entry and requiring a real annotation keeps it from being satisfied by prose, which matters because `--draft-model`'s description names `--model-draft` in its own text. Three tests cover the new assertion: a prose-only entry must not count as documented, the entry slicer must not spill into the neighbouring flag, and cutting the rendered annotation out of the live `mlxcel serve --help` must leave the alias undocumented. Validated with `cargo test --release --features metal,accelerate --test cli_help_consistency` (14 passed), the same command with `CARGO_TARGET_DIR` pointed at a directory outside the checkout, `cargo clippy --release --all-targets --features metal,accelerate -- -D warnings`, and `cargo fmt --all -- --check`. Rebuilding the CLI with `visible_alias = "model-draft"` removed turns the test red as intended, so the #464 contract is still pinned. Refs #962 * fix(tests): tighten binary resolution and alias-entry matching Review hardening on top of the previous commit. Both halves had ways to be silently wrong that the passing tests did not expose. Binary resolution now consults only signals cargo itself produces. The runtime `CARGO_BIN_EXE_*` lookup is gone: cargo never sets it at test runtime, so it was dead code, and keeping it as an override hook would let a stale exported value beat the binary cargo just built, which is the same shape as the bug this ordering exists to fix. The `<manifest>/target/<profile>/<name>` reconstruction is gone too: besides being wrong under `CARGO_TARGET_DIR`, it cannot know the target triple under `--target`, and its `cfg!(debug_assertions)` profile guess is wrong for a custom profile such as `--profile test-fast`, so it could hand back a stale binary from an unrelated build. What remains is the compile-time `CARGO_BIN_EXE_*` path and a `current_exe()`-derived profile directory that now verifies its parent really is `deps` rather than assuming the layout, so a test binary running from a copied location cannot spawn an unrelated sibling that happens to share the name. `resolve_repo_binary` returns the path and the diagnostic report from one pass, marking the candidate it selected, so the report can no longer contradict the choice it is explaining, and the help test stats the filesystem once instead of twice. `flag_help_entry` matched the signature by prefix against any line. That is not sound as a general helper: measured against the live help, `--metrics` prefix-matches the separate `--metrics-port <PORT>` entry and an example command line in `after_long_help`. It now matches the whole trimmed line, which is exactly how clap's long help renders a signature, and the short-form branch requires a real two-character short flag so a hyphen-bulleted description line cannot anchor the slice on prose. `documented_aliases` searched the whole entry for a bare `[alias: ` / `[aliases: ` substring, so a bracketed span written by hand in a doc comment would have satisfied the #464 contract with no `visible_alias` attribute behind it. The help output already carries prose brackets on other flags, so this was a live foot-gun rather than a theoretical one. The annotation must now begin a line, which is how clap always renders it, and the parser still handles an annotation that wraps across lines. New coverage: `cli_binaries_resolve_to_the_path_cargo_built_them_at` is the regression test the resolution defect never had, asserting the resolved path is the one cargo built rather than a reconstruction, which holds under `CARGO_TARGET_DIR`, a custom profile, and a cross build alike. `flag_help_entry_ignores_hyphen_bulleted_prose` and a prefix-sibling case in `flag_help_entry_stops_at_the_next_flag` cover the matcher; an inline-prose bracket case and a wrapped-annotation case cover the parser. The mutation test now splices the annotation-stripped entry back into the full help and re-runs the entry lookup, so it exercises the whole path rather than only the parser. Validated with `cargo test --release --features metal,accelerate --test cli_help_consistency` (16 passed), the same under `CARGO_TARGET_DIR` outside the checkout, and `cargo clippy --release --all-targets --features metal,accelerate -- -D warnings`. Rebuilding `mlxcel-server` with `visible_alias = "draft-max"` removed turns the test red on the `--draft <DRAFT>` assertion, confirming the tightened form still pins the contract. Refs #962 * test(cli): cover the deps-derived binary resolution branch resolve_repo_binary's second candidate, a binary path derived from the running test binary's own deps/ location, only fires for a binary name the compile-time CARGO_BIN_EXE_* match arm does not list. Every existing test in this file, including the new cli_binaries_resolve_to_the_path_cargo_built_them_at regression test, only calls resolve_repo_binary with "mlxcel" or "mlxcel-server", both of which always resolve through the compile-time candidate, so the deps-parent layout check added alongside this branch was never exercised. speculative_bench is a real fourth [[bin]] target in Cargo.toml that no CARGO_BIN_EXE_* case names and that no integration test spawns, making it the live binary that takes this code path. The new test resolves it and asserts the result sits in the same profile directory as the binaries CARGO_BIN_EXE_* names directly. Also reviewed CONTRIBUTING.md, docs/architecture.md, and the docs/ tree for anything documenting CARGO_TARGET_DIR or how integration tests locate binaries; none exists, so no documentation needed updating for this test-harness-only change. Validation: - cargo fmt --all -- --check: clean. - DEVELOPER_DIR=/Applications/Xcode-26.6.0.app/Contents/Developer cargo test --release --features metal,accelerate --test cli_help_consistency: 17 passed. Refs #962
be-free-snowboy
pushed a commit
to freestylejs/snowbrain-mlxcel
that referenced
this pull request
Oct 27, 2026
… updates (lablup#828) Bumps the minor-and-patch group with 10 updates in the / directory: | Package | From | To | | --- | --- | --- | | [serde](https://github.com/serde-rs/serde) | `1.0.228` | `1.0.229` | | [anyhow](https://github.com/dtolnay/anyhow) | `1.0.103` | `1.0.104` | | [thiserror](https://github.com/dtolnay/thiserror) | `2.0.18` | `2.0.19` | | [clap](https://github.com/clap-rs/clap) | `4.6.1` | `4.6.2` | | [tokio](https://github.com/tokio-rs/tokio) | `1.52.3` | `1.53.0` | | [futures](https://github.com/rust-lang/futures-rs) | `0.3.32` | `0.3.33` | | [uuid](https://github.com/uuid-rs/uuid) | `1.23.5` | `1.24.0` | | [cxx](https://github.com/dtolnay/cxx) | `1.0.197` | `1.0.198` | | [globset](https://github.com/BurntSushi/ripgrep) | `0.4.18` | `0.4.19` | | [cc](https://github.com/rust-lang/cc-rs) | `1.2.67` | `1.3.0` | Updates `serde` from 1.0.228 to 1.0.229 - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.228...v1.0.229) Updates `anyhow` from 1.0.103 to 1.0.104 - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.103...1.0.104) Updates `thiserror` from 2.0.18 to 2.0.19 - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@2.0.18...2.0.19) Updates `clap` from 4.6.1 to 4.6.2 - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.6.1...clap_complete-v4.6.2) Updates `tokio` from 1.52.3 to 1.53.0 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.52.3...tokio-1.53.0) Updates `futures` from 0.3.32 to 0.3.33 - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.32...0.3.33) Updates `uuid` from 1.23.5 to 1.24.0 - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](uuid-rs/uuid@v1.23.5...v1.24.0) Updates `cxx` from 1.0.197 to 1.0.198 - [Release notes](https://github.com/dtolnay/cxx/releases) - [Commits](dtolnay/cxx@1.0.197...1.0.198) Updates `cxx-build` from 1.0.197 to 1.0.198 - [Release notes](https://github.com/dtolnay/cxx/releases) - [Commits](dtolnay/cxx@1.0.197...1.0.198) Updates `globset` from 0.4.18 to 0.4.19 - [Release notes](https://github.com/BurntSushi/ripgrep/releases) - [Changelog](https://github.com/BurntSushi/ripgrep/blob/master/CHANGELOG.md) - [Commits](BurntSushi/ripgrep@globset-0.4.18...globset-0.4.19) Updates `cc` from 1.2.67 to 1.3.0 - [Release notes](https://github.com/rust-lang/cc-rs/releases) - [Changelog](https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/cc-rs@cc-v1.2.67...cc-v1.3.0) --- updated-dependencies: - dependency-name: anyhow dependency-version: 1.0.104 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: cc dependency-version: 1.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: clap dependency-version: 4.6.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: cxx dependency-version: 1.0.198 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: cxx-build dependency-version: 1.0.198 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: futures dependency-version: 0.3.33 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: globset dependency-version: 0.4.19 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: serde dependency-version: 1.0.229 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: thiserror dependency-version: 2.0.19 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor-and-patch - dependency-name: tokio dependency-version: 1.53.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch - dependency-name: uuid dependency-version: 1.24.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
be-free-snowboy
pushed a commit
to freestylejs/snowbrain-mlxcel
that referenced
this pull request
Oct 27, 2026
…ablup#996) * fix(tests): honor CARGO_TARGET_DIR and clap's singular alias label The nightly `make verify` job has been red on `main` because of two independent defects in the integration test suite, both surfacing in `tests/cli_help_consistency.rs`. `repo_binary_path` in `tests/common/mod.rs` reconstructed the binary location as `CARGO_MANIFEST_DIR/target/<profile>/<name>`, which is wrong whenever `CARGO_TARGET_DIR` is set. Both `nightly-verify.yml` and `release.yml` set it to `$HOME/.cargo-target/mlxcel` so the self-hosted runner keeps a warm build cache outside the checkout, so cargo built the binaries there while the tests looked for them in the workspace. Every test in the file failed on CI with `No such file or directory` while passing locally, and the helper is shared by 12 other integration test files. It now prefers the compile-time `CARGO_BIN_EXE_<name>` path cargo hands every integration test target, which already accounts for the profile, the target triple, and `CARGO_TARGET_DIR`, then falls back to a `current_exe()`-derived profile directory for binaries it does not name by hand, then to the previous reconstruction. The existing `if !binary.exists()` skip guards in the real-model tests keep working because the helper still returns a path unconditionally; the new `binary_resolution_report` lists every candidate and whether it exists, and the two spawn sites in the help test fold it into their panic so the next occurrence is diagnosable from the panic alone. `drafter_flag_aliases_are_documented_on_both_binaries` asserted on the literal `[aliases: X]`. `clap_builder` 4.6.2 introduced a `pluralize` call in its help template that renders `[alias: X]` for exactly one visible alias, and each of the four flags carries exactly one, so all four assertions broke on a dependency bump (`3ccb693a3`, lablup#828) rather than a code change. All four aliases are still declared and still documented, so the fix belongs in the assertion, not in the CLI. It now locates the flag's own help entry, parses the alias names out of whatever alias annotation clap rendered, and matches on the name. Accepting either label keeps the assertion working across clap's singular/plural rendering and across a future second alias; scoping it to one entry and requiring a real annotation keeps it from being satisfied by prose, which matters because `--draft-model`'s description names `--model-draft` in its own text. Three tests cover the new assertion: a prose-only entry must not count as documented, the entry slicer must not spill into the neighbouring flag, and cutting the rendered annotation out of the live `mlxcel serve --help` must leave the alias undocumented. Validated with `cargo test --release --features metal,accelerate --test cli_help_consistency` (14 passed), the same command with `CARGO_TARGET_DIR` pointed at a directory outside the checkout, `cargo clippy --release --all-targets --features metal,accelerate -- -D warnings`, and `cargo fmt --all -- --check`. Rebuilding the CLI with `visible_alias = "model-draft"` removed turns the test red as intended, so the lablup#464 contract is still pinned. Refs lablup#962 * fix(tests): tighten binary resolution and alias-entry matching Review hardening on top of the previous commit. Both halves had ways to be silently wrong that the passing tests did not expose. Binary resolution now consults only signals cargo itself produces. The runtime `CARGO_BIN_EXE_*` lookup is gone: cargo never sets it at test runtime, so it was dead code, and keeping it as an override hook would let a stale exported value beat the binary cargo just built, which is the same shape as the bug this ordering exists to fix. The `<manifest>/target/<profile>/<name>` reconstruction is gone too: besides being wrong under `CARGO_TARGET_DIR`, it cannot know the target triple under `--target`, and its `cfg!(debug_assertions)` profile guess is wrong for a custom profile such as `--profile test-fast`, so it could hand back a stale binary from an unrelated build. What remains is the compile-time `CARGO_BIN_EXE_*` path and a `current_exe()`-derived profile directory that now verifies its parent really is `deps` rather than assuming the layout, so a test binary running from a copied location cannot spawn an unrelated sibling that happens to share the name. `resolve_repo_binary` returns the path and the diagnostic report from one pass, marking the candidate it selected, so the report can no longer contradict the choice it is explaining, and the help test stats the filesystem once instead of twice. `flag_help_entry` matched the signature by prefix against any line. That is not sound as a general helper: measured against the live help, `--metrics` prefix-matches the separate `--metrics-port <PORT>` entry and an example command line in `after_long_help`. It now matches the whole trimmed line, which is exactly how clap's long help renders a signature, and the short-form branch requires a real two-character short flag so a hyphen-bulleted description line cannot anchor the slice on prose. `documented_aliases` searched the whole entry for a bare `[alias: ` / `[aliases: ` substring, so a bracketed span written by hand in a doc comment would have satisfied the lablup#464 contract with no `visible_alias` attribute behind it. The help output already carries prose brackets on other flags, so this was a live foot-gun rather than a theoretical one. The annotation must now begin a line, which is how clap always renders it, and the parser still handles an annotation that wraps across lines. New coverage: `cli_binaries_resolve_to_the_path_cargo_built_them_at` is the regression test the resolution defect never had, asserting the resolved path is the one cargo built rather than a reconstruction, which holds under `CARGO_TARGET_DIR`, a custom profile, and a cross build alike. `flag_help_entry_ignores_hyphen_bulleted_prose` and a prefix-sibling case in `flag_help_entry_stops_at_the_next_flag` cover the matcher; an inline-prose bracket case and a wrapped-annotation case cover the parser. The mutation test now splices the annotation-stripped entry back into the full help and re-runs the entry lookup, so it exercises the whole path rather than only the parser. Validated with `cargo test --release --features metal,accelerate --test cli_help_consistency` (16 passed), the same under `CARGO_TARGET_DIR` outside the checkout, and `cargo clippy --release --all-targets --features metal,accelerate -- -D warnings`. Rebuilding `mlxcel-server` with `visible_alias = "draft-max"` removed turns the test red on the `--draft <DRAFT>` assertion, confirming the tightened form still pins the contract. Refs lablup#962 * test(cli): cover the deps-derived binary resolution branch resolve_repo_binary's second candidate, a binary path derived from the running test binary's own deps/ location, only fires for a binary name the compile-time CARGO_BIN_EXE_* match arm does not list. Every existing test in this file, including the new cli_binaries_resolve_to_the_path_cargo_built_them_at regression test, only calls resolve_repo_binary with "mlxcel" or "mlxcel-server", both of which always resolve through the compile-time candidate, so the deps-parent layout check added alongside this branch was never exercised. speculative_bench is a real fourth [[bin]] target in Cargo.toml that no CARGO_BIN_EXE_* case names and that no integration test spawns, making it the live binary that takes this code path. The new test resolves it and asserts the result sits in the same profile directory as the binaries CARGO_BIN_EXE_* names directly. Also reviewed CONTRIBUTING.md, docs/architecture.md, and the docs/ tree for anything documenting CARGO_TARGET_DIR or how integration tests locate binaries; none exists, so no documentation needed updating for this test-harness-only change. Validation: - cargo fmt --all -- --check: clean. - DEVELOPER_DIR=/Applications/Xcode-26.6.0.app/Contents/Developer cargo test --release --features metal,accelerate --test cli_help_consistency: 17 passed. Refs lablup#962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the minor-and-patch group with 10 updates in the / directory:
1.0.2281.0.2291.0.1031.0.1042.0.182.0.194.6.14.6.21.52.31.53.00.3.320.3.331.23.51.24.01.0.1971.0.1980.4.180.4.191.2.671.3.0Updates
serdefrom 1.0.228 to 1.0.229Release notes
Sourced from serde's releases.
Commits
7fc3b4cRelease 1.0.2296d6e9a1Merge pull request #3085 from dtolnay/syn36dec3b7Update to syn 3cfe6692Resolve mut_mut pedantic clippy lint1023d07Update actions/upload-artifact@v6 -> v7dd682c2Update actions/checkout@v6 -> v75f0f18bUpdate ui test suite to nightly-2026-06-0163a1498Regenerate stderr with trybuild normalization fixesfa7da4aFix unused_features warning6b1a178Unpin CI miri toolchainUpdates
anyhowfrom 1.0.103 to 1.0.104Release notes
Sourced from anyhow's releases.
Commits
1dbe186Release 1.0.104f6479f8Update to syn 3Updates
thiserrorfrom 2.0.18 to 2.0.19Release notes
Sourced from thiserror's releases.
Commits
e13a785Release 2.0.190a0e76cUpdate to syn 3ec42ea7Update actions/upload-artifact@v6 -> v74178c4aUpdate actions/checkout@v6 -> v77214e0eIgnore items_after_statements pedantic clippy lint in testfebcc03Merge pull request #451 from vip892766gma/maint/20260521171412c50e387chore: improve thiserror maintenance pathd4a2507Raise minimum tested compiler to rust 1.8599e8a6cUnpin CI miri toolchain9ac165cPin CI miri to nightly-2026-02-11Updates
clapfrom 4.6.1 to 4.6.2Release notes
Sourced from clap's releases.
Changelog
Sourced from clap's changelog.
Commits
0fe0be3chore: Release480af9ddocs: Update changelog2b3ddd0Merge pull request #6340 from liskin/fix-completion-escape7ffe739fix(complete): Do not suggest options after "--"d47fc4ftest(complete): Options suggested after escape (--)Updates
tokiofrom 1.52.3 to 1.53.0Release notes
Sourced from tokio's releases.
... (truncated)
Commits
be689a3chore: prepare Tokio v1.53.0 (#8294)50f76c7chore: prepare tokio-macros v2.7.1 (#8295)f61fccaMerge 'tokio-1.52.4' into 'master' (#8290)efdba5fchore: prepare Tokio v1.52.4 (#8289)b0ba02eMerge 'tokio-1.51.4' into 'tokio-1.52.x' (#8288)7bcd2d3taskdump: remove crate disambiguators from output (#8288)f84b209chore: prepare Tokio v1.51.4 (#8286)eacb98eruntime: don't skip the driver whenbefore_parkschedules work (#8222)5e16ee0task: avoid replacing the JoinQueue waker intry_join_next(#8279)88212absync: document memory ordering guarantees for Semaphore (#8119)Updates
futuresfrom 0.3.32 to 0.3.33Release notes
Sourced from futures's releases.
Changelog
Sourced from futures's changelog.
Commits
89cc254Release 0.3.33cd9f5beci: Update release workflowd79a499Resolve rustdoc::broken_intra_doc_links warning95bbcf8Resolve rustdoc ambiguous link error303c165Resolve rustdoc::redundant_explicit_links warningf34e3f5ci: Cleanup66591a2Enable Miri for more testsab1072fSimplify target_has_atomic cfg in utility cratescf5d23bFix unsound compat01as03 implementation (fixes #2514) (#3012)8ae794fAdd portable-atomic-alloc feature and use it in FuturesUnordered (#3007)Updates
uuidfrom 1.23.5 to 1.24.0Release notes
Sourced from uuid's releases.
Commits
6a8aeabMerge pull request #896 from uuid-rs/cargo/v1.24.0e6db8ecprepare for 1.24.0 release606f236Merge pull request #892 from weifanglab/mainab848dbfeat(fmt): support encoding into MaybeUninit buffers6fa1a1efeat(fmt): support encoding into MaybeUninit buffersUpdates
cxxfrom 1.0.197 to 1.0.198Release notes
Sourced from cxx's releases.
Commits
2ac8f56Release 1.0.198a035252Merge pull request #1744 from dtolnay/syn303c55d6Update to syn 3006be77Lockfile update7055a83Bump Bazel build to rustc 1.97.1b1aaed3Regenerate MODULE.bazel.lock with bazel 9.2.033b21deMerge pull request #1742 from dtolnay/emsdkdc817f7Install emsdk using setup-emsdk action03bae8bReplace apt emscripten with emsdk9dcd6d6Bump Bazel build to rustc 1.97.0Updates
cxx-buildfrom 1.0.197 to 1.0.198Release notes
Sourced from cxx-build's releases.
Commits
2ac8f56Release 1.0.198a035252Merge pull request #1744 from dtolnay/syn303c55d6Update to syn 3006be77Lockfile update7055a83Bump Bazel build to rustc 1.97.1b1aaed3Regenerate MODULE.bazel.lock with bazel 9.2.033b21deMerge pull request #1742 from dtolnay/emsdkdc817f7Install emsdk using setup-emsdk action03bae8bReplace apt emscripten with emsdk9dcd6d6Bump Bazel build to rustc 1.97.0Updates
globsetfrom 0.4.18 to 0.4.19Commits
28c687dglobset-0.4.19f03c67echangelog: 15.2.0324f7efignore-0.4.28241b87bignore: supportGIT_CONFIG_GLOBALandGIT_CONFIG_SYSTEMfor `core.exclude...b6849daignore/walk: addWalkBuilder::emptyandWalkBuilder::from_iter8bca2ebdoc: fix typo in man page61a9fd8doc: fix typoe7b0f89lint: usecloned()orcopied()when we can767086dsearcher: hint at sequential memory map reading9548e86ignore/types: add PKGBUILD typeUpdates
ccfrom 1.2.67 to 1.3.0Release notes
Sourced from cc's releases.
Changelog
Sourced from cc's changelog.
Commits
0954016chore(cc): release v1.3.0 (#1796)e805bf3feat: inherit path remap rules from cargo trim-paths (#1794)