Skip to content

fix: patch rustls TLS handshake boundary vulnerability - #1896

Merged
inureyes merged 2 commits into
mainfrom
fix/issue-1895-rustls-handshake
Sep 15, 2026
Merged

inureyes merged 2 commits into
mainfrom
fix/issue-1895-rustls-handshake

Conversation

@inureyes

@inureyes inureyes commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Summary

Test plan

  • PASS: cargo deny --locked check against refreshed advisory database e2e640471715167f73e22eaf761f2e547adafeec; advisories, bans, licenses, and sources pass with existing warning-level notices.
  • PASS: cargo tree --locked -i rustls resolves only 0.23.45 across server TLS and HTTP clients; git diff --check.
  • PASS: 10 existing TLS configuration/certificate tests and 1 actual loopback TLS handshake/HTTP response test under test-fast, selected CPU-only with no failures or ignored tests.
  • Independent code/security/performance review: no findings. English/Korean technical reports record evidence and limits.
  • Hosted source CI: cargo-deny, WebUI bundle/contract, and OpenXLA feature compile pass; final branch checks remain required before merge. No GPU or real-model validation is claimed for this dependency-only fix.

Closes #1895

Update only the locked rustls release from 0.23.43 to 0.23.45 for RUSTSEC-2026-0285. Preserve TLS providers, feature selection, and advisory policy.

Refs #1895
@inureyes inureyes added type:security Security vulnerability or fix priority:high High priority status:review Under review labels Sep 15, 2026
@inureyes
inureyes merged commit 63f373a into main Sep 15, 2026
16 checks passed
@inureyes
inureyes deleted the fix/issue-1895-rustls-handshake branch September 15, 2026 00:20
@inureyes inureyes added status:done Completed and removed status:review Under review labels Sep 15, 2026
inureyes added a commit that referenced this pull request Sep 15, 2026
Closes #1846. Part of #1834.

## Changes

- Add scoped browser/privacy, in-memory generation defaults, live settings and explicit next-load profiles using the published `@lablup/ui-common@0.1.0-alpha.19` adapters. No implicit credential or system-prompt persistence.
- Preserve CLI/environment > profile > preset precedence, existing context/parallel/KV validation, operation identity and no hot worker mutation. Live edits detect observed fingerprint drift, retain rejected drafts and refetch effective values.
- Fix shared authentication-session fencing, modal-unmount focus, field accessible names and base64url asset-hash caching; preserve feature-off compilation and exact browser assertions.

## Validation

At source `8308a79f`, both workspace/all-target Clippy configurations, formatting, 47 contract fixtures/structural checks, both binary builds and both model-free entrypoints with relocated assets, network denial and TTY checks passed. Hosted run 34859248743 passed all executable checks; three jobs were skipped, not passed.

The runtime/UI-equivalent `153d3c73` passed 119 frontend tests, 21 local/22 hosted browser cases, deterministic bundle verification and the serialized workspace suite (11,323 passed, zero failed, 361 ignored, plus two nested tests). A subsequent GPU recovery event has unknown root cause; the maintainer explicitly deferred that investigation to finish WebUI development. This is not a claimed firmware diagnosis or a waiver of actual feature failures.

Actual Settings acceptance passed at `8308a79f`: Llama 2048/2/int8 and Granite 1024/1/fp16 reloads matched `/props` and generated responses; conflicting profiles respected all three CLI pins. Partial live PATCH/refetch, unchanged hot geometry and observed worker exit passed. Actual production-CSP browser checks at 1440/light and 390/dark passed with zero axe violations, no secret persistence and profile save without server mutation. Both temporary servers exited gracefully. Native Safari/VoiceOver and actual 200% zoom are deferred to the final integrated manual session. No CUDA runtime validation is claimed.

Final security rebase `c8a78b7c` includes #1896. Both binaries were rebuilt; 47 contracts, the complete actual Settings acceptance above, and all executable hosted checks passed again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:high High priority status:done Completed type:security Security vulnerability or fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: patch rustls TLS handshake boundary vulnerability

1 participant