Repository navigation
feat: add arch JSON recipes registry - #1606
Merged
Merged
Conversation
inureyes
added
type:enhancement
Add a stable `mlxcel arch --json` registry for recipes and automation, keeping the existing human `mlxcel arch` renderer unchanged. The registry is derived from `ALL_MODEL_TYPES`, records per-family runtime, modality, backend, distributed, drafter, and KV facts, and commits the v0.6.0 snapshot consumed by downstream recipe builds. Validated with `cargo test --lib registry --no-default-features`, `cargo test --bin mlxcel arch --no-default-features`, `cargo check --lib --tests --no-default-features`, and `cargo clippy --lib --tests --no-default-features -- -D warnings`. Refs lablup/mlxcel-internal#1508.
inureyes
force-pushed
the
feature/issue-1508-arch-json
branch
from
September 3, 2026 07:00
55918f0 to
3019b63
Compare
DeepSeek V3 and V3.2 use the MLA latent-cache layout, and the runtime KV resolver downgrades quantized requests for those config keys back to fp16. Remove the advertised int8/turbo4 modes from the arch registry snapshot and add regression coverage that rejects registry KV modes that resolve to fp16 at runtime. Refs #1508.
make recipes-registry previously redirected JSON directly into the tracked snapshot and kept running after mlxcel arch --json failed, so a serialization or write error could leave a partial registry file while refreshing CURRENT. The target now fails fast, writes JSON and CURRENT to temporary files, and replaces tracked artifacts only after the JSON command succeeds. Validated with cargo fmt --check, cargo test --lib registry --no-default-features, cargo test --bin mlxcel arch --no-default-features, cargo clippy --lib --tests --no-default-features -- -D warnings, make -n recipes-registry, make recipes-registry, and JSON parse checks. Refs lablup/mlxcel-internal#1508.
4 tasks done
inureyes
added a commit
that referenced
this pull request
Sep 3, 2026
## Summary Adds the English and Korean technical reports that were omitted when #1606 was merged. The reports document the architecture registry contract, deterministic JSON generation, runtime capability mapping, and the review corrections for DeepSeek MLA KV modes and atomic snapshot rebuilds. ## Validation - [x] Both reports follow the repository technical-report structure. - [x] English and Korean reports cover the same implementation and maintenance decisions. - [x] The commit changes only the two report files. - [x] No AI attribution is present. ## Links - Refs #1606
9 tasks done
inureyes
added a commit
that referenced
this pull request
Sep 3, 2026
## Summary Adds the standalone RT-DETRv2 detector to the machine-readable architecture registry without presenting it as a text/VLM generation model. ## What Changed - Added a deterministic standalone-family extension point after the `ALL_MODEL_TYPES` registry entries. - Registered `rt_detr_v2` with the truthful `detect` runtime, `image` input, `boxes` output, and `detection` category. - Added collision guards so standalone registry IDs and detection keys cannot shadow loadable `ALL_MODEL_TYPES` families. - Kept `generate`, `serve`, tensor parallelism, pipeline parallelism, and speculative decoding disabled for the detector. - Extended registry and CLI tests and regenerated the committed `0.6.0` snapshot. - Clarified public documentation that the JSON registry includes text/VLM model families plus standalone command runtimes. ## Validation - [x] `cargo fmt --check` - [x] `cargo test --lib registry --no-default-features` - [x] `cargo test --bin mlxcel arch --no-default-features` - [x] `cargo check --lib --tests --no-default-features` - [x] `cargo clippy --lib --tests --no-default-features -- -D warnings` - [x] `make recipes-registry` - [x] Release `mlxcel arch --json` matches `recipes/registry/0.6.0.json` byte-for-byte. - [x] The `rt_detr_v2` entry advertises only `detect`, accepts only `image`, and emits `boxes`. - [x] Standalone registry extensions cannot collide with loadable family IDs or keys. ## Links - Refs #1606 - Refs lablup/mlxcel-internal#1508
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
mlxcel arch --jsonas the machine-readable architecture registry for recipes and commits the firstrecipes/registry/0.6.0.jsonsnapshot.What changed
ALL_MODEL_TYPES, including IDs, detection keys, runtimes, modalities, outputs, backend status, tensor and pipeline parallel support, drafters, and KV cache modes.mlxcel archrenderer unchanged and adds a JSON writer with focused CLI and registry tests.fp16-only KV modes because the MLA resolver downgrades quantized requests at runtime.make recipes-registryrebuild atomically by writing JSON andCURRENTthrough temporary files and only replacing tracked artifacts aftermlxcel arch --jsonsucceeds.README.mdanddocs/supported-models.md, following the vLLM Recipes pattern of static registry data for downstream recipe builds.Test plan
cargo fmt --checkcargo test --lib registry --no-default-featurescargo test --bin mlxcel arch --no-default-featurescargo check --lib --tests --no-default-featurescargo clippy --lib --tests --no-default-features -- -D warningsmake -n recipes-registrymake recipes-registrydiff -u /tmp/mlxcel-1606-arch.json recipes/registry/0.6.0.json./target/release/mlxcel arch --json >/tmp/mlxcel-1606-arch.json 2>/tmp/mlxcel-1606-arch-json.stderr && ./target/release/mlxcel arch >/tmp/mlxcel-1606-arch.txt 2>/tmp/mlxcel-1606-arch.stderrpython3 -c "import json, pathlib; data=json.loads(pathlib.Path(\"/tmp/mlxcel-1606-arch.json\").read_text()); fam={f[\"id\"]: f for f in data[\"families\"]}; ids=list(fam); assert len(ids)==len(set(ids)); assert fam[\"deepseek_v3\"][\"kv_modes\"] == [\"fp16\"]; assert fam[\"deepseek_v32\"][\"kv_modes\"] == [\"fp16\"]; assert pathlib.Path(\"/tmp/mlxcel-1606-arch-json.stderr\").read_text() == \"\"; assert pathlib.Path(\"/tmp/mlxcel-1606-arch.stderr\").read_text() == \"\""arch --jsonwrite leftrecipes/registry/0.6.0.jsonandrecipes/registry/CURRENTunchanged.Refs lablup/mlxcel-internal#1508.