Skip to content

docs: sync PR template clippy and test commands with CONTRIBUTING.md #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inureyes merged 1 commit into from
Sep 2, 2026
Merged

docs: sync PR template clippy and test commands with CONTRIBUTING.md #1583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ For inference changes, real-checkpoint validation is required — synthetic-only
-->

- [ ] `cargo fmt --all -- --check` (enforced by CI — violations block merge)
- [ ] `cargo clippy --workspace --all-targets -- -D warnings`
- [ ] `cargo test --workspace --profile test-fast`
- [ ] `cargo clippy --workspace --all-targets --features metal,accelerate -- -D warnings`
- [ ] `cargo test --workspace --profile test-fast --features metal,accelerate --no-fail-fast -- --test-threads=1`
- [ ] `cargo deny check`
- [ ] Validated with a real checkpoint (specify which, e.g. `mlx-community/Qwen3.5-0.8B-OptiQ-4bit`): ...
- [ ] If the change moves the numbers (quantization, kernel selection, fused ops, block widths), traced it: disagreement at decided positions, and the width and context it was traced at. See [Judging a change that moves the numbers](../docs/benchmarks.md#judging-a-change-that-moves-the-numbers).
Expand Down