Repository navigation
refactor(loading): remove dead is_special_weight_model_type wrapper - #1237
Closed
DebayanSen96 wants to merge 1 commit into
Closed
DebayanSen96 wants to merge 1 commit into
DebayanSen96 wants to merge 1 commit into
Conversation
The pass-through wrapper in loading::special has zero callers; the only call site (model_metadata_tests) imports the model_metadata original directly. Delete it along with its #[allow(dead_code)].
|
|
Contributor
Author
|
Closing — contribution needs local build/test verification before review. |
6 tasks done
inureyes
added
type:refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1225.
src/loading/special.rscarries a pass-through wrapper foris_special_weight_model_typethat has zero callers and sits behind an#[allow(dead_code)]. A repo-wide grep confirms the only references are themodel_metadataoriginal, the wrapper itself, andmodel_metadata_tests.rs, which imports the original directly. Deleted the wrapper;use crate::model_metadatastays becausespecial.rsstill callsmodel_metadata::adapter_loading_unsupported_message.