Skip to content

feat: update codespaces bootstrap script - #516

Merged
achimnol merged 22 commits into
mainfrom
feature/codespaces
Sep 1, 2022
Merged

achimnol merged 22 commits into
mainfrom
feature/codespaces

Conversation

@kyujin-cho

@kyujin-cho kyujin-cho commented Jul 5, 2022 •

Copy link
Copy Markdown
Member

This PR updates codespace bootstrap script to reflect updated monorepo setup.
This resolves #499.

@kyujin-cho kyujin-cho added the type:maintenance Maintenance issue. label Jul 5, 2022
@kyujin-cho kyujin-cho self-assigned this Jul 5, 2022
@kyujin-cho kyujin-cho changed the title feat: update codespace script feat: update codespaces bootscrap script Jul 5, 2022
@kyujin-cho kyujin-cho changed the title feat: update codespaces bootscrap script feat: update codespaces bootstrap script Jul 5, 2022

@Yaminyam Yaminyam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the installation and server normal operation in the codespace environment.

@Yaminyam Yaminyam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

An error occurs while performing postCreateCommand during setup

@achimnol achimnol left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's split install-dev.sh into two parts that can be either executed at once (with no option) or separately (with --codespace-on-create, --codespace-post-create) so that we can use prebuilt containers.

  • In "on create", run docker pull compose and ./pants export :: to pre-download and populate external dependencies that takes long time to fetch and install.
  • In "post create", run any configuration and cloning of additional repositories because in this stage we have fully configured GitHub access tokens.
  • The "post create" step may be executed multiple times if we rebuild the container, so it should be safe to be executed multiple times, aka idempotence.
  • If run inside Codespace (we could check this by environment variables), we may skip several prerequisite checks (such as availability of Docker).
  • Let's explicitly add a handful range (about 10?) of forwarded TCP ports for wsproxy and explicitly configure the wsproxy worker port range as well (for v1).

@kyujin-cho

kyujin-cho commented Jul 25, 2022 •

Copy link
Copy Markdown
Member Author
  • Let's explicitly add a handful range (about 10?) of forwarded TCP ports for wsproxy and explicitly configure the wsproxy worker port range as well (for v1).

This can't be achieved within current webui's wsproxy implementation:

I'll add port 10200~10209 as exported port on devcontainer.json for desktop VSCode users.

@kyujin-cho

Copy link
Copy Markdown
Member Author

Relevant document updates will be followed after this PR is merged, on a separate PR.

@kyujin-cho
kyujin-cho requested a review from achimnol July 25, 2022 12:33
Comment thread scripts/install-dev.sh
Comment thread .devcontainer/devcontainer.json Outdated
@achimnol

achimnol commented Aug 9, 2022

Copy link
Copy Markdown
Member

image

Please take a look at this.

@achimnol

Copy link
Copy Markdown
Member

Also let's add the ssh feature config: https://github.com/cli/cli/pull/6019/files

@github-actions github-actions Bot added the comp:installer Related to Installer label Aug 30, 2022
@achimnol
achimnol merged commit e0c95fa into main Sep 1, 2022
@achimnol
achimnol deleted the feature/codespaces branch September 1, 2022 08:54
@Yaminyam Yaminyam added the size:XL 500~ LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:installer Related to Installer size:XL 500~ LoC type:maintenance Maintenance issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit codespace auto-setup

3 participants