Repository navigation
feat: update codespaces bootstrap script - #516
Merged
Merged
Conversation
Yaminyam
approved these changes
Jul 20, 2022
Yaminyam
left a comment
Member
There was a problem hiding this comment.
I checked the installation and server normal operation in the codespace environment.
Yaminyam
reviewed
Jul 20, 2022
achimnol
requested changes
Jul 20, 2022
Member
There was a problem hiding this comment.
Let's split install-dev.sh into two parts that can be either executed at once (with no option) or separately (with --codespace-on-create, --codespace-post-create) so that we can use prebuilt containers.
- In "on create", run
docker pull composeand./pants export ::to pre-download and populate external dependencies that takes long time to fetch and install. - In "post create", run any configuration and cloning of additional repositories because in this stage we have fully configured GitHub access tokens.
- The "post create" step may be executed multiple times if we rebuild the container, so it should be safe to be executed multiple times, aka idempotence.
- If run inside Codespace (we could check this by environment variables), we may skip several prerequisite checks (such as availability of Docker).
- Let's explicitly add a handful range (about 10?) of forwarded TCP ports for wsproxy and explicitly configure the wsproxy worker port range as well (for v1).
Member
Author
This can't be achieved within current webui's wsproxy implementation:
I'll add port 10200~10209 as exported port on |
Member
Author
|
Relevant document updates will be followed after this PR is merged, on a separate PR. |
achimnol
requested changes
Aug 1, 2022
Member
Member
|
Also let's add the ssh feature config: https://github.com/cli/cli/pull/6019/files |
achimnol
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR updates codespace bootstrap script to reflect updated monorepo setup.
This resolves #499.