This repository was archived by the owner on Apr 22, 2024. It is now read-only.
Default value for port_no in PortStatsRequest changed#631
Merged
hdiogenes merged 1 commit intokytos:masterfrom Jan 25, 2021
ajoaoff:issue630
Merged
Default value for port_no in PortStatsRequest changed#631hdiogenes merged 1 commit intokytos:masterfrom ajoaoff:issue630
hdiogenes merged 1 commit intokytos:masterfrom
ajoaoff:issue630
Conversation
The default value was None, which caused error when packing. It has been changed to Port.OFPP_NONE. Fixex `PackException` error running Kytos with OpenFlow 1.0 #630
ajoaoff
requested review from
a team and
rmotitsuki
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #630
📑 Description of the Change
The constructor of the class PortStatsRequest accepts a parameter named port_no.
Its default value was None, causing and error when the request was packed.
This PR changes the default value to Port.OFPP_NONE.
💻 Verification Process
All unit tests ran ok.