Skip to content

fix(discover): sanitize drive-letter colon so Windows discover finds sessions (adopt upstream #2952) - #38

Merged
kylehgc merged 1 commit into
developfrom
claude/issue-25-adopt-2952
Jul 20, 2026
Merged

kylehgc merged 1 commit into
developfrom
claude/issue-25-adopt-2952

Conversation

@kylehgc

@kylehgc kylehgc commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Adopts rtk-ai/rtk#2952 by @zbl1998-sdjn — cherry-picked preserving authorship, no amendments needed.

Closes #25

What

ClaudeProvider::encode_project_path was missing : in SANITIZED_CHARS, so every Windows cwd encoded to C:-Users-... while Claude's real project folder is C--Users-.... The slug never matched, and the default rtk discover (and rtk learn, same encoder) scanned 0 sessions on Windows. One-char fix + regression tests.

Adoption checklist (CONTEXT.md)

  • Sync: develop is even with upstream/develop (0 commits behind at branch time)
  • Repro on pre-cherry-pick binary (this Windows 11 machine, cwd C:\Users\kyleh\projects\rtk):
    Scanned: 0 sessions (last 30 days), 0 Bash commands
    
  • Cherry-pick preserving authorship (f0c7d5d, author zbl1998-sdjn), fixed behavior confirmed with the rebuilt binary:
    Scanned: 47 sessions (last 30 days), 1163 Bash commands
    Already using RTK: 799 commands (68.7%)
    
    Ground truth: this project's sessions live in ~/.claude/projects/C--Users-kyleh-projects-rtk (colon → -).
  • Quality gate: cargo fmt --all (no changes) && cargo clippy --all-targets (clean) && cargo test --all (2470 passed, 0 failed)
  • Amendments: none needed

🤖 Generated with Claude Code

…sessions

encode_project_path mirrors Claude Code's cwd -> ~/.claude/projects slug, but
never replaced the drive-letter ':' with '-'. Every Windows cwd carries one, so
the encoded slug (C:-Users-me) never matched Claude's real folder (C--Users-me)
and the default `rtk discover` scanned 0 sessions on Windows. Add ':' to
SANITIZED_CHARS; the shared encoder also fixes `rtk learn`.

Refs rtk-ai#2919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adopt upstream #2952: discover - sanitize drive-letter colon so Windows discover finds sessions

2 participants