Skip to content

adopt core: bound capture buffers to stop OOM on huge output (upstream #3333 + #3579) #104

Open

Description

@kylehgc

Upstream PRs: rtk-ai#3333 by @FlorianBruniaux (cap exec_capture, shared by ~16 filters incl. prisma/vitest/playwright/git) and rtk-ai#3579 by @thebigjc (cap raw retention in search) — related small fixes, one adoption batch.

Bug: capture() and the search path use unbounded cmd.output(), while run_streaming caps at RAW_CAP — a huge eslint JSON or a large-tree search OOM-kills the caller. Rank (b): crash/hang class.

Verified on develop (2026-08-17 sweep): src/core/stream.rs:563-590 unbounded; src/cmds/system/search.rs:1548 unbounded.

Note: rtk-ai#3505 also carries an exec_capture cap hunk — resolve overlap at adoption time.

Activity

  1. kylehgc commented on Oct 9, 2026

    @kylehgc
    OwnerAuthor

    Cross-ref upstream rtk-ai#3849: grouped grep/rg capture is still unbounded (search.rs:364-371, :528, :579). Fold into this ticket's capture-buffer cap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions