Repository navigation
Conversation
6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Refs #255
Changed files
tests/test_julia_worker.py(new): isolated pytest fake packages and subprocess JSONL harness; 11 protocol tests.Acceptance checklist — tests implemented, not executed
test_status_before_load— status before load; configured CLI flags, defaults, PID, and unloaded state.test_predict_round_trip— request ID, state/questions passthrough, default loader kwargs, latency/load timings, device.test_warm_then_predict_loads_once— warm/status/predict sequence and one resident model load.test_invalid_json_does_not_kill_worker— malformed JSON error, ignored blank line, continued status response.test_shutdown_stops_processing— early clean exit without extra stdout.test_request_error_is_reported_per_line— missing questions KeyError, bounded traceback, successful following request.test_missing_answers_become_empty_dict— empty model response normalizes to empty answers.test_stdout_carries_only_protocol_lines— parseable JSON on stdout; fake-library chatter on stderr.test_autocast_off_replaces_torch_autocast— off vs auto class names across independent processes.test_warm_on_start_failure_is_recorded— model-load exception saved in status, subsequent predict error, worker survives.test_missing_model_dir_exits_2— missing required argument and invalid--autocastvalue exit 2 with usage errors.juliaandtorchlive undertmp_path, injected via subprocessPYTHONPATH.tests NOT RUN - ChatGPT cannot execute code (written via GitHub connector; no pass counts or CI claims).
Exact test commands
Notes
The worker source on
devalready matches the specified status, warm, shutdown, predict, and load-error contracts. No production bug fix was justified.