Repository navigation
Conversation
Owner
Author
|
Consolidating this parallel draft into the earlier, equivalent fork PR #53 rather than maintaining duplicate patches. The one additional New Year day-isolation regression was carried over in commit b307487 on #53. No upstream action, original branch and commits remain available for provenance. |
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Android
InsightsScreensilently copied all of yesterday's native Journal Yes/No answers into today when the screen was opened with an empty day. The copy was immediately persisted withupsertJournal, even though the user never confirmed those observations. Merely viewing Insights could manufacture intervention and explicit No control days, contaminating effect rankings and experiment baselines.The Apple Insights screen does not auto-write previous-day answers; this also restores platform parity.
Fix
Verification
ryanbr/noop@8e4b0c16.Attribution and promotion
The original Journal system, native-vs-imported precedence, and explicit-No comparison semantics are NOOP maintainer work (including ryanbr's #1768, following digitalerdude #682). This corrects a missed screen-open call site without reimplementing those systems.
Fork-only draft, not an upstream request. Independent review, current-head CI and per-PR approval required. This project is PolyForm Noncommercial, not OSI-open-source.