Repository navigation
[AI-2761] Align Settings, setup, and launcher chrome with the kit - #932
Conversation
PR Summary by QodoAlign Settings and first-run setup with the launcher kit
AI Description
Diagram
High-Level Assessment
Files changed (10)
|
Code Review by Qodo
1. Merge subject breaks required format
|
| <Setter Property="Background" Value="Transparent" /> | ||
| <Setter Property="BorderThickness" Value="0" /> | ||
| </Style> | ||
| <!-- Standalone fields (Settings, setup, sign-in prompts): pin the Fluent ring to our |
There was a problem hiding this comment.
1. Pull request issue links are misplaced 📘 Rule violation ⚙ Maintainability
The PR title begins with [AI-2761], while the description has no reference line containing both a GitHub closing reference and the Linear key. Reviewers encounter the issue key in the title instead of the required description location, and no GitHub issue is linked for closure.
There was a problem hiding this comment.
Title is now Restyle Settings and first-run setup to the launcher kit. Description opens with No GitHub issue — AI-2761 — there is no public issue to close.
| <Setter Property="Background" Value="Transparent" /> | ||
| <Setter Property="BorderThickness" Value="0" /> | ||
| </Style> | ||
| <!-- Standalone fields (Settings, setup, sign-in prompts): pin the Fluent ring to our |
There was a problem hiding this comment.
2. Merge subject breaks required format 📘 Rule violation ⚙ Maintainability
The sole commit subject is [AI-2761] Restyle Settings and first-run setup to the launcher kit, which does not end with a parenthesized GitHub issue reference. When this subject is used on merge, the bracketed Linear key also prevents it from matching the required single-clause subject pattern.
ChangesThroughout
Setup
Settings
Home launcher
|
No GitHub issue — AI-2761
What & why
Settings and first-run used Fluent's default fields, radios, checks, and dropdown — a bright ring and accent-blue glyphs — on the Kcap canvas. Setup also clipped Import under a fixed footer, and the Sign in CTA sat in leftover fill. Shared
kcapField, type, and button chrome now skin those surfaces; the step body scrolls; agent/import chips wrap at 220 DIP; in-step CTAs sit 14px under copy. Settings splits name and capacity into independently saved cards with an occupancy pill; choosing all-public visibility warns that private-repo sessions are visible; the launcher connection banner overlays so the composer does not move.Where to look
ComboBox.kcapFielditem/popup styles, the step-bodyScrollViewer(a*grid row inside a scroll host collapses),SignInStepView's top dock (the CTA must not live in leftover fill), andLauncherPaneView'sConnectionBanner(last child, so it overlays).Verification
dotnet run --project test/Capacitor.App.Tests.Unit/Capacitor.App.Tests.Unit.csproj1928 passed, 0 failed (14s).
Visuals