[AI-665] Normalize workspaceFolder before Cursor path redaction

[alexeyzimarev]

Summary

• CursorCommand.ResolveWorkspaces now normalises folderPath once (Path.GetFullPath + TrimEnd) and yields the canonical native form to all call sites.
• CursorPayloadAssembler.RedactPaths tries three variants of the (trimmed) repoPath — forward-slash, native backslash, and JSON-escaped backslash (\\\\) — replacing the escaped form first so we don't consume half of an escape sequence. Comparison is OrdinalIgnoreCase on Windows, Ordinal on POSIX.
• Closes the Windows-only path-leak gap where bubble JSON used backslashes and workspace.json used forward slashes (or vice versa).

Follow-up from Qodo review on #85 (bug #3 — Windows correctness).
Linear: AI-665

Test plan

• Redacts_paths_with_trailing_separator_on_repoPath — trailing-slash variant matches.
• Redacts_backslash_paths_when_repoPath_uses_forward_slash — escaped Windows form in bubble JSON is stripped.
• Redacts_forward_slash_paths_when_repoPath_uses_backslash — inverse case.
• Redacts_unescaped_backslash_paths_in_object_typed_params — object-typed params via GetRawText().
• Existing Redacts_absolute_paths_to_relative still passes.
• All 26 Cursor unit tests + 814 CLI unit tests pass.
• AOT publish clean.

🤖 Generated with Claude Code

[linear-code]

AI-665

[qodo-code-review]

Review Summary by Qodo

Fix Windows path redaction with normalized workspace folders

🐞 Bug fix

Walkthroughs

Description

• Normalize folderPath in CursorCommand.ResolveWorkspaces to canonical native form
• Enhance RedactPaths to handle path separator variants (forward, backward, escaped)
• Fix Windows path-leak where workspace.json and bubble JSON use different separators
• Add comprehensive tests for cross-platform path redaction scenarios

Diagram

flowchart LR
  A["workspace.json<br/>folderPath"] -->|NormalizePath| B["Canonical<br/>Native Form"]
  B -->|ResolveWorkspaces| C["Normalized<br/>repoPath"]
  C -->|RedactPaths| D["Path Variants<br/>forward/backward/escaped"]
  D -->|Replace| E["Redacted JSON<br/>with /repo"]

Loading

File Changes

1. src/Kapacitor.Cli.Core/Cursor/CursorPayloadAssembler.cs 🐞 Bug fix +31/-3

Implement multi-variant path redaction for cross-platform compatibility

• Enhanced RedactPaths to handle three path separator variants: forward-slash, native backslash,
 and JSON-escaped backslash
• Added case-insensitive comparison on Windows and case-sensitive on POSIX
• Replaces escaped backslash form before raw backslash to avoid consuming half of escape sequences
• Trims trailing separators from repoPath for consistent matching

src/Kapacitor.Cli.Core/Cursor/CursorPayloadAssembler.cs

---

2. src/Kapacitor.Cli/Commands/CursorCommand.cs 🐞 Bug fix +11/-3

Normalize folderPath to canonical form in ResolveWorkspaces

• Added path normalization in ResolveWorkspaces to canonicalize folderPath once using
 NormalizePath
• Yields normalized folder path to all call sites instead of raw workspace.json value
• Ensures downstream consumers receive consistent canonical native form
• Moved normalization earlier in the flow to apply before workspace database path construction

src/Kapacitor.Cli/Commands/CursorCommand.cs

---

3. test/Kapacitor.Cli.Tests.Unit/Cursor/CursorPayloadAssemblerTests.cs 🧪 Tests +43/-0

Add comprehensive cross-platform path redaction tests

• Added test for trailing separator handling on repoPath with forward slash
• Added test for redacting JSON-escaped backslash paths when repoPath uses forward slashes
• Added test for inverse scenario with backslash repoPath and forward-slash bubble JSON
• Added test for unescaped backslash paths in object-typed params via GetRawText()

test/Kapacitor.Cli.Tests.Unit/Cursor/CursorPayloadAssemblerTests.cs

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. Silent workspace skip ✓ Resolved 🐞 Bug ◔ Observability

Description

ResolveWorkspaces swallows any exception from NormalizePath(folderPath) and continues without
logging, which can cause the command to report “No matching Cursor workspace found” without
indicating which workspace entry was invalid. This makes real workspace discovery failures
significantly harder to diagnose (especially for --all).

Code

src/Kapacitor.Cli/Commands/CursorCommand.cs[R409-414]

Evidence

The new try/catch { continue; } around NormalizePath(folderPath) drops entries without any
diagnostics, and RunAsync only reports a generic error when the resolved workspace list is empty.

src/Kapacitor.Cli/Commands/CursorCommand.cs[407-414]
src/Kapacitor.Cli/Commands/CursorCommand.cs[35-40]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`CursorCommand.ResolveWorkspaces` catches all exceptions thrown by `NormalizePath(folderPath)` and silently `continue`s. When this happens for all workspaces, `RunAsync` emits only a generic “No matching Cursor workspace found.” message, giving users no actionable clue about which `workspace.json` (or `folder` value) is malformed.

### Issue Context
The PR intentionally normalizes `folderPath` early to feed a canonical repo path to redaction and other downstream logic. That’s good, but the new failure mode should be diagnosable.

### Fix Focus Areas
- src/Kapacitor.Cli/Commands/CursorCommand.cs[407-414]
- src/Kapacitor.Cli/Commands/CursorCommand.cs[35-40]

### Suggested fix
- In the `catch` around `NormalizePath(folderPath)`, capture the exception and write a one-line warning to `Console.Error` including `wsJsonPath` (or `subdir`), the problematic `folderPath`, and `ex.Message`, then continue.
- Optional: keep the generic “No matching…” message, but consider mentioning that some workspaces may have been skipped due to invalid paths.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[alexeyzimarev]

Pushed fix for the silent-skip finding in 13f1c79:

The new catch around NormalizePath(folderPath) now writes a one-line diagnostic to Console.Error with the workspace storage subdir, the problematic folder path, and the exception message before continuing — so users get an actionable clue when a workspace.json's folder URI is malformed instead of just the generic "No matching Cursor workspace found."

All 26 Cursor unit tests still pass.