Repository navigation
Capture the alias script's output before grepping it in CI - #848
Conversation
grep -q closes the pipe at its first match. A stable tag prints beta then stable, so the second line hit EPIPE, exited the script with 1 and failed the bundle assertion on v1.0.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
PR Summary by QodoPrevent stable-tag bundle assertions from failing on closed pipes
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. Merge subject omits its issue link
|
| aliases="$(bash scripts/promote-desktop-aliases.sh releases/releases.osx-arm64.json "${{ steps.version.outputs.VERSION }}")" | ||
| grep -qx beta <<<"$aliases" |
There was a problem hiding this comment.
1. Merge subject omits its issue link 📘 Rule violation ⚙ Maintainability
The commit subject Capture the alias script's output before grepping it in CI does not end with the required (#<digits>) suffix. When this commit enters repository history under that subject, readers and automation cannot associate it with the required GitHub issue from the subject alone.
Agent Prompt
## Issue description
The commit subject does not end with the required GitHub issue reference in `(#<digits>)` form.
## Fix Focus Areas
- .github/workflows/ci.yml[223-224]
## Recommended Fix
Amend the commit subject to a single imperative clause of at most 80 characters ending in the actual GitHub issue reference. Do not add that reference to the pull request title.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| aliases="$(bash scripts/promote-desktop-aliases.sh releases/releases.osx-arm64.json "${{ steps.version.outputs.VERSION }}")" | ||
| grep -qx beta <<<"$aliases" |
There was a problem hiding this comment.
2. Pull request lacks required issue links 📘 Rule violation § Compliance
The description begins with No tracker issue on either side and contains neither a GitHub closing reference nor a Linear issue key. Without one reference line containing both identifiers, the change cannot be connected to the tracker records required for review and audit.
Agent Prompt
## Issue description
The pull request description lacks the required reference line containing both a GitHub closing reference and a Linear issue key.
## Fix Focus Areas
- .github/workflows/ci.yml[223-224]
## Recommended Fix
Establish the required tracker records, then add one description line such as `Closes #123 AI-456` using the actual identifiers. Do not invent identifiers or place them in the pull request title.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
No tracker issue on either side: the failure surfaced on the v1.0.0 tag build (CI run 34466915928).
What & why
The bundle assertion pipes the alias-promotion script into
grep -qx beta, andgrep -qexits at its first match and closes the pipe. Every earlier tag was a beta, so the script printed one line and stopped. A stable tag printsbetathenstable, and the second line hits the closed pipe: bash'sechoreturns 1 underset -e, and the step'spipefailfails the job that the Release workflow waits on. The output is now captured first, then grepped.Verification
Reproduced against a one-version manifest with SIGPIPE ignored, as under the Actions runner:
bash scripts/run-shell-tests.sh: every suite reportsok.🤖 Generated with Claude Code