Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,9 @@ public async Task spool_drain_runs_before_current_event_under_budget() {
// is still stuck undelivered. Simulates: sessionStart is already spooled from a prior failed
// invocation; this invocation's top-of-method drain retries it and hits a transient failure
// (503) so it stays queued, while postToolUse's own POST succeeds.
[Test]
// Bare NotInParallel: the spawn override is process-wide, so any concurrent peer's spawn lands
// in this list. The class key is not enough — its cohort excludes only the env-override readers.
[Test, NotInParallel]
Comment thread
qodo-code-review[bot] marked this conversation as resolved.
public async Task telemetry_hook_does_not_recovery_spawn_while_an_earlier_canonical_event_is_still_stuck() {
var sid = Guid.NewGuid().ToString("N");
var spool = new HookSpool(Config.PathTo("spool"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ namespace Capacitor.Cli.Tests.Unit.Commands;
/// catch-all every one of these paths already has, so an effect-only assertion passes with the guard
/// deleted; six review rounds found exactly that, repeatedly.</para>
/// </summary>
// The two spawn guards below install WatcherManager.ProcessStarterForTesting and Dispose nulls it,
// both process-global: a concurrent peer's spawn lands in this class's counter, and its own override
// is cleared under it. Bare, as every other writer of that seam already carries.
[NotInParallel]
public class UnusableUrlGuardTests : IDisposable {
[TempHome] public required TempHome Home { get; init; }

Expand Down