Repository navigation
Draw a brand mark for every harness in the desktop app - #1584
Merged
Merged
Conversation
Mistral publishes no Vibe-specific mark, so Vibe takes Mistral's pixel M, the mark its CLI draws itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (2 skipped: 2 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: adding brand marks for all harnesses in the desktop app. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
PR Summary by QodoAdd brand marks for all desktop harnesses
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1. Muse Assistant chips look inconsistent
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+38
to
+39
| ["muse-assistant"] = | ||
| "M5.91 3.869C6.777 3.869 7.396 4.546 7.396 5.607C7.396 6.669 7.225 7.626 6.941 9.659C6.738 11.084 6.389 13.258 6.243 14.162C6.523 13.628 7.178 12.378 7.294 12.144C8.666 9.375 10.096 6.901 10.508 6.246C11.054 5.372 11.535 5.021 12.278 5.021C12.664 5.022 13.124 5.217 13.352 5.477C13.66 5.829 13.725 6.398 13.714 7.019C13.698 7.97 13.574 9.486 13.405 11.177C13.33 11.929 13.185 13.466 13.087 14.496C13.965 12.925 15.591 10.035 16.246 9.025C16.817 8.146 17.392 7.579 18.164 7.579C18.83 7.579 19.651 8.05 19.603 9.302C19.531 11.149 19.264 15.174 19.143 16.979C19.96 15.79 21.033 14.029 21.436 13.367C21.842 12.698 22.26 12.157 22.894 12.139C23.544 12.12 23.979 12.562 23.999 13.244C24.019 13.927 23.612 14.694 23.072 15.565C22.486 16.511 21.831 17.523 21.033 18.468C20.236 19.413 19.502 20.131 18.384 20.131C17.382 20.131 16.677 19.465 16.628 18.246C16.602 17.607 16.723 16.234 16.814 15.16C16.92 13.917 17.048 12.717 17.137 11.923C16.256 13.535 14.402 16.912 13.568 18.23C12.752 19.52 12.355 19.974 11.493 19.975C10.631 19.975 10.253 19.354 10.241 18.42C10.227 17.407 10.988 11.324 11.246 9.297C10.828 10.191 9.801 12.385 9.157 13.69C8.534 14.953 7.489 17.135 6.73 18.393C6.184 19.298 5.57 19.975 4.66 19.975C3.75 19.975 3.236 19.363 3.236 18.379C3.236 17.395 3.521 15.756 3.827 13.723C3.98 12.739 4.155 11.667 4.352 10.53C4.496 9.708 4.746 8.26 4.9 7.371C4.2 8.461 2.941 10.423 2.558 11.014C2.131 11.671 1.749 12.15 1.115 12.15C0.416 12.15 0 11.605 0 10.971C0 10.337 0.322 9.848 0.846 8.988C1.518 7.883 2.726 6.377 3.388 5.586C4.168 4.654 4.947 3.869 5.91 3.869Z", |
There was a problem hiding this comment.
1. Muse assistant chips look inconsistent 🔗 Cross-repo conflict ≡ Correctness
The desktop app adds a muse-assistant brand path, but the server's shared vendor-mark table has no corresponding entry, so the server vendor chip continues using its monogram fallback. The server nevertheless exposes muse-assistant as a recorded vendor with session routes, so the same vendor appears across both repositories with different visual treatment.
Agent Prompt
Issue description
The desktop app now renders a brand mark for `muse-assistant`, but the server-side vendor chip definition has no `muse-assistant` path and will retain the monogram fallback for the same recorded vendor.
Fix Focus Areas
- src/Capacitor.App/Views/VendorIcons.cs[38-39]
- /cross_repos/kcap-server/src/Capacitor.Ui/Components/Kit/VendorMarks.cs[8-43]
Recommended Fix
Add the identical `muse-assistant` path to the server's `VendorMarks` table, then update or add the server UI test covering the vendor chip so both repositories render the same mark.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Collaborator
Author
There was a problem hiding this comment.
Not a conflict: this compares against kcap-server main. The companion PR kurrent-io/kcap-server#2490 adds the identical muse-assistant path to VendorMarks. There, KitVendorChipTests requires every Vendor.Recorded member (which includes muse-assistant) to render an SVG mark. Both surfaces draw the same mark once both land.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-3939 (no GitHub issue; one would import as a duplicate of the Linear issue)
What & why
Mistral Vibe, Kiro, Pi, Antigravity, Grok and Muse showed monogram tiles in the harness picker, agent chip and session rail. They now draw brand marks, the same path strings as the server's vendor chip (kurrent-io/kcap-server#2490). Mistral publishes no Vibe-specific logo, and Vibe's CLI draws Mistral's pixel M, so Vibe uses the Mistral AI icon from Simple Icons. Kiro, Antigravity, Pi and Grok come from LobeHub Icons (MIT). Muse uses muse.ai's own squiggle SVG, scaled to 24×24.
Where to look
The marks keep each vendor's existing
VendorTilestint as their fill, so no colours change.Verification
VendorIconsTestsparses each harness's mark in headless Avalonia and requires non-empty bounds, for everyHarnessRegistryidentity plusmuse-assistant. I wrote the Kiro and Grok paths with fully separated arc flags, then rasterised each one to confirm it renders pixel-identical to the source SVG.🤖 Generated with Claude Code
Summary by CodeRabbit