Repository navigation
[AI-3418] app: Add full-size onboarding with CLI-compatible setup - #1326
Merged
Merged
Conversation
PR Summary by QodoAdd full-size, CLI-compatible desktop onboarding
AI Description
Diagram
High-Level Assessment
Files changed (92)
|
Code Review by Qodo
1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
The finished flow hands its window to the main surface in place, so the rail opens where onboarding was; a window closed mid-flow still abandons it, as before.
The Connect choice is now part of the Sign-in step, so a "workspace you already have" answer stays on the page and signs in from there. The re-auth dialog keeps its own view.
A refresh of an install whose capture half is absent touches only the tools, so the npm postinstall keeps a --tools-only install free of hooks.
…#1267) A row answered tools-only installs with --tools-only, so the page needs the CLI that carries it.
The import outlives onboarding: leaving the page or closing onboarding keeps it running, and only shutdown stops it. Discovery reports each repository's own window counts for the picker.
The machine name is saved when the daemon is enabled, not on a page of its own, because the service is installed under it.
Classification clears Busy after the status read resumes off the UI thread. ReactiveCommand leaves that can-execute there, so Avalonia keeps Check again and Enable daemon disabled.
The pane chrome was showing the launcher's Start daemon sentence on every step. The wizard drops that button name, and the line is visible only while the daemon step is current.
The repository rows bind Stop, so setting an owner to skip left them on shared. The titling checkbox was centred in the theme's hit target, and the daemon step no longer says to continue past a failure it refuses.
Hooks store the bare command, so turning a harness on before the login shell can find the bundled binary installs hooks that record nothing.
Continue stays secondary while the step already shows its own filled action, so two filled buttons never sit on one screen.
Back sits on the left and the forward button is last. A finished sign-in or harness install stays until that press.
Continue and Cancel use the same footer columns as Skip and Next, so Back stays on that line. The checkbox theme draws its mark in a 32px row, which a 16px box clips.
A committed pick stays on the workspace list. A failed harness install still holds for Retry.
nortonandreev
force-pushed
the
norton/ai-3418-onboarding-production
branch
from
October 6, 2026 17:00
37bf040 to
23c0fd5
Compare
Contributor
Author
|
User-facing changelog for the full onboarding branch:
|
Git Bash treats a bare "kcap" as the kcap.exe beside it, so the existence guard failed silently and stopped the Windows app bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ding-production # Conflicts: # src/Capacitor.Cli/Commands/PluginCommand.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1267 — AI-3418
What & why
Adds a six-step desktop onboarding flow for sign-in, workspace creation, harness connections, explicit privacy choices, history import, and daemon setup. Users can leave for the main app and return to setup; existing CLI-completed setup is recognized. macOS installation supports safe replacement with a newer version, and desktop packages include the harness assets needed for setup.
Where to look
The shared CLI startup gate remains authoritative. Wizard actions resolve the selected profile freshly; consent acknowledgements retain their separate literal identity. History import can outlive onboarding, but restarting setup warns before interrupting it.
Verification
dotnet build Capacitor.slnx --no-restore: zero warnings/errors.