[AI-3318] Gate the startup-failure tests on loop signals, not a polled count

[realtonyyoung]

AI-3318 (no GitHub issue)

What & why

Two AppStartupTests waited for DaemonClientService's loop to start and end by polling a counter against a 5-second wall-clock deadline, and on a loaded Windows runner the loop was not scheduled in time. ForeverRunClient now completes a start signal when its enumeration begins and an end signal when the last one finishes. The tests await those with a 30-second bound, and still assert no enumeration is live afterwards, so a loop that restarted after disposal would still fail.

Verification

AppStartupTests passes locally on macOS. The Windows scheduling delay was not reproduced.

🤖 Generated with Claude Code

[linear-code]

AI-3318

[qodo-code-review]

PR Summary by Qodo

Use loop signals to stabilize startup-failure tests

🧪 Tests 🐞 Bug fix 🕐 10-20 Minutes

AI Description

• Replace counter polling with loop-start and loop-end signals in two startup-failure tests.
• Allow 30 seconds for slow runners while still asserting no enumeration remains live.

Diagram

graph TD
  T["Startup tests"] --> S["Service start"] --> R["Client loop"] --> A(["Started signal"]) --> D["Service disposal"] --> E(["Ended signal"]) --> Z["Zero live assertion"]

Loading

High-Level Assessment

Use the proposed signals: they express the loop lifecycle directly. Merely extending the polling deadline would retain timing-dependent checks and repeated polling.

Files changed (1) +20 / -15

Tests (1) +20 / -15

AppStartupTests.csWait for client-loop lifecycle signals instead of polling +20/-15

Wait for client-loop lifecycle signals instead of polling

• ForeverRunClient now signals when enumeration starts and when the last enumeration ends. Two disposal tests await those signals with a 30-second bound, then assert the live count is zero; the five-second polling helper is removed.

test/Capacitor.App.Tests.Unit/AppStartupTests.cs

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[realtonyyoung]

/agentic_review

[qodo-code-review]

No code changes since the last review — review skipped