Conversation
The addPrefix methods in SubscriptionFilter were incorrectly calling builder.setRegex() instead of builder.addPrefix(), causing prefix filters to be sent as regex matches on the wire. This could match streams that contain the prefix anywhere in the name rather than only at the start. Fixes #374
w1am
deleted the
w1am/dev-1044-in-a-catch-up-subscription-filtering-by-stream-name-prefix
branch
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #374
The addPrefix methods in SubscriptionFilter were incorrectly calling builder.setRegex() instead of builder.addPrefix(), causing prefix filters to be sent as regex matches on the wire. This could match streams that contain the prefix anywhere in the name rather than only at the start.