fix: ensure onCancelled callback is properly invoked#375
Merged
Conversation
The onCancelled callback was not being called when a subscription was stopped by the user or when the onEvent handler threw an exception. This fixes both cases by propagating cancellation through the consumer and catching handler exceptions in ReadResponseObserver. Also reorders onSubscriptionConfirmation to complete the future before calling the listener, preventing race conditions.
1 task
w1am
deleted the
w1am/listener-on-cancelled-callback-not-being-invoked
branch
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #373
The
onCancelledcallback was not being called when a subscription was stopped by the user or when theonEventhandler threw an exception. This fixes both cases by propagating cancellation through the consumer and catching handler exceptions inReadResponseObserver.Also reorders
onSubscriptionConfirmationto complete the future before calling the listener.