Skip to content

Network streaming - #519

Merged
amitschendel merged 23 commits into
mainfrom
feature/stream-network
Apr 17, 2025
Merged

Network streaming#519
amitschendel merged 23 commits into
mainfrom
feature/stream-network

Conversation

@amitschendel

Copy link
Copy Markdown
Contributor

Overview

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

github-actions Bot commented Apr 1, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@amitschendel amitschendel changed the title Adding base code Network streaming Apr 1, 2025
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

github-actions Bot commented Apr 1, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@amitschendel
amitschendel requested a review from amirmalka April 1, 2025 14:07
Signed-off-by: Amir Malka <amirm@armosec.io>
@github-actions

github-actions Bot commented Apr 2, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amir Malka <amirm@armosec.io>
@github-actions

github-actions Bot commented Apr 3, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amir Malka <amirm@armosec.io>
@github-actions

github-actions Bot commented Apr 3, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amir Malka <amirm@armosec.io>

if len(slimPod.OwnerReferences) > 0 {
workloadKind = slimPod.OwnerReferences[0].Kind
if utils.WorkloadKind(workloadKind) == utils.ReplicaSet {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitschendel What in case of pod -> job -> cronjob?

@amirmalka

Copy link
Copy Markdown
Contributor

I have tested this and it's working overall :)

  1. I added a check in case of empty network stream, skip sending
  2. See comment regarding CJ
  3. I think we should add some basic logs
  4. When testing it saw these errors :
    {"level":"error","ts":"2025-04-03T14:01:28Z","msg":"NetworkStream - failed to get shared container data","error":"container 8740ce379c602799cac9f0fed51a5b05edf4fb1c67ecf35225076962f0285ea3 not found in shared data","container ID":"8740ce379c602799cac9f0fed51a5b05edf4fb1c67ecf35225076962f0285ea3}
    If it's a real error let's keep it, otherwise let's change the log

@github-actions

github-actions Bot commented Apr 3, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

github-actions Bot commented Apr 7, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

amirmalka
amirmalka previously approved these changes Apr 10, 2025
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
amitschendel marked this pull request as ready for review April 14, 2025 08:30
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

Signed-off-by: Amit Schendel <amitschendel@gmail.com>
@amitschendel
amitschendel requested a review from amirmalka April 17, 2025 10:32
@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@amitschendel amitschendel added the release Create release label Apr 17, 2025
@amitschendel
amitschendel merged commit 0fc384a into main Apr 17, 2025
@amitschendel
amitschendel deleted the feature/stream-network branch April 17, 2025 14:06
@matthyx matthyx moved this from WIP to To Archive in KS PRs tracking Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants