SANDBOX-1845 | Lookup user signups by email - #156
Open
MikelAlejoBR wants to merge 1 commit into
Open
Conversation
Since the emails are hashed, looking up users by their email meant that we had to figure a way to hash the emails to then attempt to get their user signups. This command does that for us. Assisted-by: Cursor with Opus 4.6 Jira-ticket: SANDBOX-1845
|
|
||
| // No user signups? It means that it was not found. | ||
| if len(userSignups.Items) == 0 { | ||
| return fmt.Errorf(`user signup not found with email "%s"`, email) |
Contributor
There was a problem hiding this comment.
Technically it's not an error if no users found. Shouldn't we just print that no user with such email found?
| return fmt.Errorf(`user signup not found with email "%s"`, email) | ||
| } | ||
|
|
||
| return ctx.PrintObject(&userSignups.Items[0], "UserSignup") |
Contributor
There was a problem hiding this comment.
They maybe multiple users with the same email. Our SSO supports it.
Comment on lines
+17
to
+18
| Use: "user-info <email>", | ||
| Short: "Get the user signup by email", |
Contributor
There was a problem hiding this comment.
This is a great idea 👍
I'm wondering, how about extending the existing get sub-command with an optional --email flag that would use the provided email, hash it, and include it as a label selector?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the emails are hashed, looking up users by their email meant that we had to figure a way to hash the emails to then attempt to get their user signups. This command does that for us.
Assisted-by: Cursor with Opus 4.6
Jira-ticket: SANDBOX-1845