Repository navigation
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
/kind bug
What steps did you take and what happened:
When I wrote some (unrelated) unit test that calls klog.InitFlags with a new flag set while some other goroutine was calling klog for logging, go test -race reported a data race:
WARNING: DATA RACE
Write at 0x00000b7b6d60 by goroutine 202:
flag.newBoolValue()
/usr/local/go/src/flag/flag.go:128 +0x208
flag.(*FlagSet).BoolVar()
/usr/local/go/src/flag/flag.go:715 +0x214
k8s.io/kubernetes/vendor/k8s.io/klog/v2.InitFlags()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:428 +0x1e6
k8s.io/kubernetes/test/e2e/framework.AfterReadingAllFlags()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/test_context.go:490 +0x69
k8s.io/kubernetes/test/e2e/framework/internal/unittests/cleanup.TestCleanup()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/test/e2e/framework/internal/unittests/cleanup/cleanup_test.go:125 +0x427
testing.tRunner()
/usr/local/go/src/testing/testing.go:1446 +0x216
testing.(*T).Run.func1()
/usr/local/go/src/testing/testing.go:1493 +0x47
Previous read at 0x00000b7b6d60 by goroutine 2743:
k8s.io/kubernetes/vendor/k8s.io/klog/v2.(*loggingT).output()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:881 +0x375
k8s.io/kubernetes/vendor/k8s.io/klog/v2.(*loggingT).printDepth()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:717 +0x31b
k8s.io/kubernetes/vendor/k8s.io/klog/v2.ErrorDepth()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:1537 +0x10b
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime.logError()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:115 +0x1d
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime.HandleError()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:109 +0x138
k8s.io/kubernetes/pkg/controlplane.(*Controller).RunKubernetesService.func2()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controlplane/controller.go:254 +0x51
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:157 +0x48
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.BackoffUntil()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:158 +0xce
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:135 +0x10d
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.NonSlidingUntil()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:111 +0xf1
k8s.io/kubernetes/pkg/controlplane.(*Controller).RunKubernetesService()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/controlplane/controller.go:249 +0xa5
k8s.io/kubernetes/pkg/controlplane.(*Controller).RunKubernetesService-fm()
<autogenerated>:1 +0x44
k8s.io/kubernetes/pkg/util/async.(*Runner).Start.func2()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/util/async/runner.go:45 +0x47
What did you expect to happen:
No data race.
Anything else you would like to add:
I believe the reason is that calls like flagset.BoolVar(&logging.toStderr, "logtostderr", logging.toStderr, "log to standard error instead of files") (the line at klog.go:428) write the default value. InitFlags shouldn't do that.
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Activity
aojea commentedon Sep 7, 2022
klog/klog.go
Lines 418 to 438 in 02fe323
shouldn't that function be locked?
pohly commentedon Sep 7, 2022
That wouldn't work, some flags are implemented so that they use atomic read/writes. I have a different solution, but GitHub currently doesn't let me create the PR.
pohly commentedon Sep 7, 2022
/assign
pohly commentedon Sep 7, 2022
See #349
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
10 remaining items
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1
build: update to klog v2.80.1