Repository navigation
Regenerate API compatibility suppressions so packing succeeds again - #295
Merged
Merged
Conversation
Polyfill 11.4.5 changed the nullability annotations on its ExperimentalAttribute and DefaultInterpolatedStringHandler shims, which package validation reports as CP0014/CP0015 between net9.0 and net10.0. Every nightly release has failed at pack since 2026-10-14. Schema's file also carried net7.0 entries for a framework it no longer targets, which ApiCompat reports as unnecessary suppressions. Schema.Cpp had no file at all. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B1AYPNe9rDK8FtuQgiKTnT
|
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: every nightly Analyze & Release run since 2026-10-14 has failed at pack, with
Pack failed for 2 project(s): Schema (exit code 1), Schema.Cpp (exit code 1). Nothing has been released since 2026-10-13.After: both projects pack cleanly.
Package validation reports CP0014/CP0015 between net9.0 and net10.0. The diagnostics are on two Polyfill shim types,
ExperimentalAttributeandDefaultInterpolatedStringHandler, whose nullability attributes differ between the two builds. The timing points at the Polyfill 11.4.4 → 11.4.5 bump, but that is inferred, not bisected. These are shim types Polyfill embeds, not Schema's own API, so suppressing them is the documented ktsu.Sdk answer.How:
dotnet pack -p:ApiCompatGenerateSuppressionFile=true, building with the Roslyn 5.9 compiler that CI uses.Schema.Cpphad no suppression file before, so this adds one.Schema's file was also carrying net7.0 entries for a framework it no longer targets. ApiCompat reports those as unnecessary suppressions, and regenerating drops them.One caveat: I verified locally on SDK 10.0.112, not on the runner's 10.0.402. The PR's CI runs tests only, so the next push to main is what proves pack.
Generated by Claude Code