ci: adopt the consolidated .NET workflow - #409
Conversation
Every ktsu .NET repository carried its own copy of dotnet.yml and they had drifted into five different files. This replaces the local copy with one canonical workflow that is byte-identical in every repository, folding in the drift rather than flattening it. The drift, and where it went: * macOS is back in the test matrix. It had been excluded org-wide because a macOS runner widened one repository's target frameworks to include a net10.0-ios head needing a workload this job does not install. That widening is now opt-in, so every other repository stops paying for it. UI test projects still run on Linux only, so a macOS cell stays cheap. * The UI-test rule is now "Linux runs them, every other platform does not", rather than naming Windows, so a platform added later gets the cheap treatment by default instead of silently inheriting the expensive one. * The Linux coverage report's paths are rewritten to this job's workspace before analysis. Sonar matches coverage to source by path, so a Linux-only suite's coverage was being dropped without a word. The step no-ops where there is no Linux report. * The test and release jobs install the 8.0 and 9.0 runtimes alongside the pinned SDK, because test projects commonly multi-target every framework their library publishes and the test host needs those runtimes present. global.json still pins the SDK, so this only adds runtimes. * Coverage exclusions are extensible per repository through the SONAR_COVERAGE_EXCLUSIONS_EXTRA variable, so a repository with a file that cannot be executed rather than one nobody has tested yet can say so without editing this file and making every other repository carry its paths. * A SonarQube Cloud outage skips analysis instead of failing the build, and is never dressed up as a pass. Where the gate is blocking, an outage still fails. * Stale comments explaining one repository's circumstances are rewritten to explain the shared rule, with the measurements kept and attributed. Nothing in the pipeline's shape changed: the same jobs, the same steps, the same order. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015qxqZVzN8CJcDxTb5gtWua
|
Both of those matrix cells existed before this change — the old workflow already ran ubuntu and windows. This PR adds a macOS cell, and macOS passed. A change that only adds a platform cannot break the two that were already there, and the one it did add is green. The diff here is exactly one file, I verified this reasoning rather than assuming it: on ktsu-dev/BlastMerge#12, which shows the same shape, I checked out the branch and ran the failing test on a machine with no GitHub workflow involved at all. It fails identically there, from source byte-identical to So this is a pre-existing failure on What this PR actually changes is working: the Sonar outage probe, the Linux coverage-path rewrite, the extra 8.0/9.0 runtimes and the macOS cell all behaved as intended. This PR is mergeable once the pre-existing suite failure is dealt with, separately from the workflow change. Happy to look at that as its own piece of work if you want it. Generated by Claude Code |
|
Correction to my comment above: I swept this PR while the macOS job was still queued — macOS runners start several minutes after ubuntu and windows within the same run — and read "not failed" as "passed". All three cells are red. That invalidates the argument I gave, but not the conclusion, which the real cause actually strengthens: That is a NuGet audit advisory under warnings-as-errors. It fails wherever the project is built, on any operating system, and the build never reached a test — so adding the macOS cell exposed nothing new, it just reproduced what ubuntu and windows were already reporting. Two further corrections to my earlier wording, both in the same direction:
The position is unchanged. This is pre-existing and independent of the one file this PR changes ( Generated by Claude Code |
Adopts the one canonical
.github/workflows/dotnet.yml, byte-identical across every ktsu .NET repository. They had drifted into five different files; this folds the drift in rather than flattening it.What this repository gains
net10.0-ioshead, which needed a workload this job does not install; that widening is now opt-in. UI tests stay Linux-only, so the cell stays cheap.global.jsonstill pins the SDK, so this adds runtimes without changing what builds.SONAR_COVERAGE_EXCLUSIONS_EXTRAvariable, unset here.Same four jobs, same steps, same order.
Already merged and green: ktsu-dev/KtsuBuild#128 (live SonarCloud analysis, quality gate passed), ktsu-dev/Invoker#43 (all four matrix cells, macOS included), ktsu-dev/ImGuiApp#396 (where the blocking-gate fix was found and proven).
Built by anchored transforms that refuse to apply on a missing or ambiguous anchor; checked by 18 structural assertions over the parsed YAML, comment-stripped diffs against all five variants, and nine pwsh cases over both Sonar scripts capturing process exit codes and written
$GITHUB_OUTPUT.🤖 Generated with Claude Code
https://claude.ai/code/session_015qxqZVzN8CJcDxTb5gtWua
Generated by Claude Code