Eliminate per-frame enum reflection/boxing in combo and property-grid enum rows - #397
Merged
Merged
Conversation
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix enum combo rows to reduce allocations on every frame
Eliminate per-frame enum reflection/boxing in combo and property-grid enum rows
Sep 13, 2026
matt-edmondson
marked this pull request as ready for review
September 13, 2026 12:17
|
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Enum-backed combo paths were doing
Enum.GetNames/Enum.GetValuesin render-time code, causing repeated allocations every frame;Combo<TEnum>also used a non-genericArraypath that introduced avoidable boxing. This change moves enum metadata to per-closed-type static caches and rewires affected call sites without changing public APIs or enum-selection behavior.Render-path allocation removal
EnumCache<TEnum>with staticValuesandNames, initialized once per enum type.ImGuiWidgets.Combo<TEnum>PropertyGrid.Enum<TEnum>EnumComboname enumeration pathBoxing-free enum selection in
Combo<TEnum>Array/GetValueusage to typed array indexing.GetValueconversion path.Behavior preserved for out-of-range enum values
PropertyGrid.Enum<TEnum>guard (index >= 0 && index < values.Length) so cast/out-of-set values (including flags combinations) still render as “no selection” rather than faulting.Focused cache behavior coverage