Do not render a soft hyphen that directly follows a visible hyphen [patch] - #149
Merged
Merged
Conversation
ChunkWord marked the chunk after "well-" as hyphenated when a soft hyphen followed the visible one, so a break there rendered "well--" and overhung the line width. The visible hyphen already ends the chunk, so the soft hyphen no longer marks the next one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzC1o7LFYHYaoWmVy1NLcp
|
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135
What changed
ChunkWordsplits a word after a visible hyphen and resetshyphenBefore. A soft hyphen right after that visible hyphen then took the "consecutive soft hyphens" branch, which sethyphenBefore = trueon the next chunk. When the wrap broke at that point, the iterator appended a second-. So"well-known".NominalWordWrap(5, 1)produced"well--", which is 6 characters on a 5-character line.That branch now sets
hyphenBeforeonly when the previous chunk does not already end in-, which is the fix the triage suggested. The visible hyphen already marks the break, so the soft hyphen adds nothing. Consecutive soft hyphens after ordinary text keep their existing behaviour.Tests
In
StringExtensionsTests:NominalWordWrapDoesNotDoubleAVisibleHyphenFollowedByASoftHyphenis the issue's case. It expects["well-", "known"].NominalWordWrapDoesNotDoubleAVisibleHyphenFollowedBySeveralSoftHyphenscovers the same position with two soft hyphens.NominalWordWrapKeepsAVisibleHyphenFollowedByASoftHyphenOnOneLineWhenItFitschecks that the unbroken text is stillwell-known, with the soft hyphen stripped.Verification
StringExtensions.csreverted, the first two tests fail. The third passes either way; it guards against regressions.🤖 Generated with Claude Code
https://claude.ai/code/session_01CzC1o7LFYHYaoWmVy1NLcp
Generated by Claude Code