Skip to content

Add Privileged and Non-Privileged RBAC Configurations with Documentation - #812

Merged
chaitanyaenr merged 1 commit into
krkn-chaos:mainfrom
abhinavs1920:rbac-feature
May 22, 2025
Merged

chaitanyaenr merged 1 commit into
krkn-chaos:mainfrom
abhinavs1920:rbac-feature

Conversation

@abhinavs1920

@abhinavs1920 abhinavs1920 commented May 15, 2025 •

Copy link
Copy Markdown
Contributor

Description

This pull request introduces privileged and non-privileged RBAC configurations for Krkn, enabling users to run chaos scenarios based on their access level. It adds YAML files for Role, ClusterRole, RoleBinding, and ClusterRoleBinding in a new rbac directory, covering namespace-scoped and cluster-wide permissions.

For writing the RBAC policies, I referred to the Kubernetes RBAC documentation (https://kubernetes.io/docs/reference/access-authn-authz/rbac/), Krkn’s scenario documentation (https://krkn-chaos.github.io/krkn/docs/scenarios/), and got refrence from Chaos Mesh’s permission management guide (https://chaos-mesh.org/docs/manage-user-permissions/).

Documentation

  • Is documentation needed for this update?

If checked, a documentation PR must be created and merged in the website repository.

Related Documentation PR (if applicable)

krkn-chaos/website#66

Issue

It will resolve the issue #759

@abhinavs1920

Copy link
Copy Markdown
Contributor Author

Hi @chaitanyaenr, @paigerube14,

After some research and navigating through various resources to understand RBAC policies, I’ve successfully created the privileged and non-privileged RBAC configurations for Krkn. My next task is to develop comprehensive documentation for this feature, which I’m currently working on.

I have a quick question: Should I also include the rbac.md file in the docs directory of the Krkn repository? 😅

Thanks! 😄

@tsebastiani
tsebastiani force-pushed the main branch 2 times, most recently from 0c931ca to 4c9cd5b Compare May 15, 2025 08:14
@paigerube14

Copy link
Copy Markdown
Collaborator

Thanks so much for this PR! We'll have a review soon, but it looks like there's an issue when you rebased with main. Try using these steps to see if you can rebase https://krkn-chaos.dev/docs/contribution-guidelines/git-pointers/#rebase-with-upstream. We also normally try to have 1 commit per PR if you can squash them into one that would be great!

No, the docs should all live in the https://github.com/krkn-chaos/website repo. We're slowly moving them over to there and any new docs we've created are already there. It would be great if you could add the details of these files with links into the docs as well.

@abhinavs1920

Copy link
Copy Markdown
Contributor Author

Thanks so much for this PR! We'll have a review soon, but it looks like there's an issue when you rebased with main. Try using these steps to see if you can rebase https://krkn-chaos.dev/docs/contribution-guidelines/git-pointers/#rebase-with-upstream. We also normally try to have 1 commit per PR if you can squash them into one that would be great!

Yepp I read the contribution guidelines mentioning squash all your commits to one, I will rebase my branch with main again and update my PR with only single commit.

No, the docs should all live in the https://github.com/krkn-chaos/website repo. We're slowly moving them over to there and any new docs we've created are already there. It would be great if you could add the details of these files with links into the docs as well.

Sure will add the documentation for rbac in krkn-chaos/website repo

Thankss!!

Signed-off-by: Abhinav Sharma <abhinavs1920bpl@gmail.com>
@abhinavs1920

Copy link
Copy Markdown
Contributor Author

Hi @paigerube14 @shahsahil264
The documentation branch for this issue has been merged.
Can you please review it too?

Thanks!!

@paigerube14 paigerube14 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chaitanyaenr
chaitanyaenr merged commit 7e4b2af into krkn-chaos:main May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants