Skip to content

fix(build): remove the personal URL from bundle banners - #859

Open
Doomguy-BFG9000 wants to merge 1 commit into
krisk:mainfrom
Doomguy-BFG9000:fix/851-bundle-banner
Open

Doomguy-BFG9000 wants to merge 1 commit into
krisk:mainfrom
Doomguy-BFG9000:fix/851-bundle-banner

Conversation

@Doomguy-BFG9000

Copy link
Copy Markdown

Summary

  • Remove the personal URL from the generated JavaScript banner while preserving the project homepage, author name, copyright, and Apache 2.0 notice.
  • Rebuild the tracked bundles and add a regression test for every JavaScript bundle.

Fixes #851.

Validation

  • The banner test failed for all 12 bundles before the change and passed for all 12 after rebuilding.
  • The before-and-after bundle comparison found only the removed URL. All five declaration files were byte-identical.
  • On Windows with Node 24.22.2, the build, lint, and type check passed. All 461 tests passed with a local junction for the package-types fixture after Windows denied directory symlink creation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken author url

1 participant