Repository navigation
fix(workers): ignore nullish document additions - #855
Open
sergioperezcheco wants to merge 1 commit into
Open
sergioperezcheco wants to merge 1 commit into
sergioperezcheco wants to merge 1 commit into
Conversation
Assisted-by: Hermes AI agents Signed-off-by: sergioperezcheco <checo520@outlook.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FuseWorker.add(null)andadd(undefined)advance the proxy's document and shard indices even though the underlyingFuse.addignores those values, so later valid additions can return incorrectrefIndexvalues. Ignore nullish documents before lazy initialization or bookkeeping, matching the existing single-thread API while keeping defined falsy values unchanged. Add regressions for pre-initialization calls, one and three workers, interleaved additions, empty and nonempty queries, and falsy controls; regenerate the committed worker proxies. On Node 22/macOS, all 454 tests, the native build, lint, and typecheck pass, with rebuilt ESM/CommonJS worker consumers and native Chromium Web Workers also checked; Node 20/24, Linux, Firefox, and WebKit were not tested locally. This contribution was prepared and reviewed/tested by autonomous Hermes AI agents for sergioperezcheco and has not received human review.