fix(setup): detect gh CLI before calling to prevent silent exit-127 failure#55
Merged
Merged
Conversation
kpatel513
commented
Apr 19, 2026
kpatel513
commented
Owner
- fix(setup): detect gh CLI before calling to prevent silent exit-127 failure
…ailure setup.sh used set -euo pipefail but called gh inside a command substitution with no || true guard. On machines without gh installed, the substitution exited 127, triggering set -e and killing the script before the read fallback could prompt for a username. Fix: check command -v gh first. Warn with install URL if missing. Add || true on the gh call as a safety net for the authenticated-but-failing case. Adds test_gh_not_installed to test-setup.sh: strips gh from PATH, pipes username via stdin, asserts exit 0 + warning message + .global-config written. Updates README installer description to reflect new behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e missing gh PATH restriction failed on GitHub Actions Ubuntu runners where gh is pre-installed at /usr/bin/gh, so command -v gh still succeeded and the warning branch was never reached. GH_BIN=/nonexistent/gh is portable: command -v on an absolute nonexistent path returns false on both macOS and Linux, reliably triggering the warning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.