Repository navigation
ADR-004 latest dependency versions: Dependabot version updates + Express 5 migration - #155
Merged
Merged
Conversation
Record the policy of keeping every dependency on its latest stable release, majors included, enforced by Dependabot version updates. Refs #154 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HcKxmDJ1KBXLKgbTxp7Wtx
Enforce ADR-004: weekly version updates for npm, pip, NuGet, Docker, docker-compose and GitHub Actions. Minor/patch bumps are grouped per directory; majors get their own PR. Refs #154 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HcKxmDJ1KBXLKgbTxp7Wtx
Upgrade express 4.22 -> 5.2.1 (supersedes Dependabot #147), per ADR-004. Express 5 leaves req.body undefined when a request has no parsable body, which made POST /api/apps without a body crash in createApp's destructuring and return 500 instead of 400. Default the body to {} in the route handler and cover both no-body and empty-JSON cases with HTTP-level tests. Refs #154 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HcKxmDJ1KBXLKgbTxp7Wtx
koydas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154. Supersedes #147.
Changes
docs/adr/ADR-004-latest-dependency-versions.md, linked inREADME.md): every dependency tracks its latest stable release, majors included; majors are migrated, not ignored; held-back dependencies must be documented next to anignorerule..github/dependabot.yml: enables weekly version updates for npm (/,client,apps-service,agent-service), pip, NuGet, Docker (8 directories), docker-compose and GitHub Actions. Minor/patch grouped per ecosystem; majors get their own PR. Validated against the SchemaStore schema.req.bodyundefined when a request has no parsable body, which turnedPOST /api/appswithout body into a 500 (TypeErrorincreateApp's destructuring) instead of 400. Route handler now passesreq.body ?? {}; new HTTP-level tests intests/appsRoutes.test.js(fails on Express 5 without the fix, passes with it). 19/19apps-servicetests pass; lockfile resolves only from registry.npmjs.org, no install scripts,npm auditclean.Expected follow-ups once merged
Dependabot will open major-version PRs that need manual handling:
TargetFrameworkis migrated in the same PR.postgres:16,mongo:7,mssql:2022-latest: engine majors require a data migration (pg_upgrade, Mongo FCV); CI starts from empty volumes and won't catch it.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01HcKxmDJ1KBXLKgbTxp7Wtx