Repository navigation
[AI] Issue #129: [FEATURE] Early validation of prerequisites and external payloads - #149
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d4b3d7c68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- scripts/lib/prompts.mjs: add existsSync to node:fs import, remove
require('fs').existsSync call, restore \\w+ in interpolatePrompt regex
- scripts/lib/config.mjs: add existsSync to node:fs import, remove
require('fs').existsSync calls in validateStartup
https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
🔍 Automated Code Review🏷️ Change ClassificationType: mixed | Tests expected: yes — Executable code and behavioral files are modified. ✅ Summary
|
koydas
added
the
changes-requested
|
@codex review Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3612c6e1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…est.yml - scripts/lib/config.mjs: remove @jest/globals import and test cases appended by auto-fix; tests belong in scripts/tests/, not production modules - .github/workflows/test.yml: restore c8 coverage steps replaced by non-existent npm run coverage script https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
|
@codex review Generated by Claude Code |
koydas
added
changes-requested
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58f0b44fb1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- scripts/generate_issue_change.mjs: call validateStartup() at the top of main() for early prerequisite and prompt-file validation - scripts/tests/config.test.mjs: add 7 tests covering all env-var failure branches and the happy path of validateStartup - scripts/tests/entrypoints.test.mjs: add GitHub startup env vars to generate_issue_change tests broken by the new validateStartup call - scripts/tests/github_output.test.mjs: same fix for integration tests https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
|
@codex review Generated by Claude Code |
koydas
added
changes-requested
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10e0fa5146
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- .github/workflows/code-generation.yml: pass GITHUB_TOKEN, GITHUB_REPOSITORY, GITHUB_EVENT_PATH explicitly in the Generate AI change step so validateStartup() prerequisites are met - CHANGELOG.md: add [Unreleased] Changed entry for the validateStartup call added to scripts/generate_issue_change.mjs (PR #149) https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
|
@codex review Generated by Claude Code |
koydas
added
changes-requested
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8402001b0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…on docs - scripts/lib/config.mjs: validateStartup() now checks generation-system.md instead of auto-fix-system.md, matching what generate_issue_change.mjs actually loads at runtime - docs/code-generation.md: restore full operator documentation stripped by auto-fix attempt 1 (b3612c6) https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
|
@codex review Generated by Claude Code |
koydas
added
changes-requested
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a79797a7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ISSUE_BODY is optional — loadConfigFromEnv() applies a '(no body provided)' fallback for empty/absent values. Requiring it in validateStartup() would abort generation for valid issues with no body before the fallback runs. Updated CHANGELOG entry and removed the corresponding test case. https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
|
@codex review Generated by Claude Code |
koydas
added
changes-requested
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64f6fabfb4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- CI Coverage section: config.mjs, llm_client.mjs, and output_writer.mjs are all CI-enforced (≥80%) via dedicated c8 steps in test.yml; the doc incorrectly said only checkpoint.mjs was enforced. - Cross-workflow artifact download: auto-fix-pr uses gh api + curl (GET /actions/artifacts?name=...) not gh run list. https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
koydas
added
changes-requested
|
@codex review Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c797f1c970
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The 'CI Coverage Enforcement' section still listed only checkpoint.mjs and said config.mjs was code-review-only. Updated to list all four c8-enforced modules (checkpoint, config, llm_client, output_writer). https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
koydas
added
changes-requested
|
@codex review Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0049140833
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds two tests covering the generation-system.md and generation-user.md missing-file branches of validateStartup(), completing coverage of all failure paths required by AGENTS.md for new exported functions. https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
|
@codex review Generated by Claude Code |
koydas
added
changes-requested
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8aba7fc53d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace renameSync-based tests with isolated temp directories to avoid mutating shared prompt fixtures during concurrent test runs. validateStartup now accepts an optional promptsDirOverride for this purpose; production callers pass no argument and get the real prompts directory as before. https://claude.ai/code/session_01SEVs5KVZr6sYKRRbVe6Rt7
|
@codex review Generated by Claude Code |
koydas
added
changes-requested
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
AI Generated Change
Added validateStartup function to scripts/lib/config.mjs and modified scripts/lib/prompts.mjs to throw with file path if prompt file does not exist
Closes #129