chore: bump @types/node from 22.19.17 to 26.2.0 - #28
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.17 to 26.2.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 26.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
cb23b16 to
4b87548
Compare
|
Claude finished @dependabot[bot]'s task in 3m 30s —— View job Dependency review:
|
| }, | ||
| "devDependencies": { | ||
| "@types/node": "^22.0.0", | ||
| "@types/node": "^26.2.0", |
There was a problem hiding this comment.
Type/runtime skew worth a conscious decision: this package declares "engines": { "node": ">=20" } (line 13) and ci.yml builds on Node 20, but the type definitions now describe Node 26.
Nothing in src/ uses a post-20 API today (process.env, process.exit, and the global fetch/FormData/Blob), so this is not a breakage — but tsc will no longer reject a Node 21–26-only API if one gets added later, and it would fail at runtime on the minimum supported Node. The conventional fix is to keep @types/node at the lowest supported runtime major (^20) rather than the newest.
Either pin back to ^20 or raise engines to match — but don't leave the two four majors apart silently.
…rompts claude-review.yaml still told the dependency reviewer that engines was node >= 20 — the very instruction that produced the review on #28. Left alone, the next @types/node major would be judged against a floor that no longer exists. Rewritten to read the floor from package.json instead of naming a version, so it can't drift again. CI now runs a ['22','24'] matrix: 22 is the declared floor, 24 is what release.yml publishes from, and previously only the floor was exercised before a tag. fail-fast is off so one version failing still reports the other. CLAUDE.md gains the list of files that must move together when the floor changes — the 'raise deliberately' instruction previously lived only in dependabot.yml, which now goes silent by design.
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps @types/node from 22.19.17 to 26.2.0.
Commits