You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR splits the single Mintlify page into per-topic subpages (overview, prerequisites, installing, upgrading, uninstalling, tls-proxy, karpenter, configuration) with a CardGroup index on the overview. It's a well-executed, low-risk documentation change.
Verification
Template wiring is sound. Every entry point in mintlify/*.md.gotmpl calls a define that exists in _mintlify_templates.gotmpl, and each of those resolves its body.* / mintlify.* sub-templates. No dangling template references.
CardGroup links all resolve. The 7 <Card href=...> targets in mintlify.overviewBody each map to a file that was added (prerequisites, installing, upgrading, uninstalling, tls-proxy, karpenter, configuration). Cross-page links inside partials (e.g. mintlify.upgrading → /helm/k8s_reporter/installing, mintlify.installing → /helm/k8s_reporter/configuration) also point at real pages.
Link handling is consistent.mintlify.paramField rewrites https://docs.kosli.com/ → / so the values.yaml doc links render as internal Mintlify links on the config page while staying absolute in the README. The values.yaml link updates (README-section → docs-page URLs) match the new page structure.
The prior duplication concern — largely addressed 👍
The earlier review flagged parallel mintlify.* copies of README prose. The second commit ("reuse partials") is a good response: shared prose now lives in body.* partials in _templates.gotmpl and is consumed by both the extra.* (README) and mintlify.* (docs) sides, with a clear header comment documenting the split. That's a real improvement.
Residual maintenance note (non-blocking)
The three large sections — mintlify.installing / mintlify.tlsProxy / mintlify.karpenter — are still full prose duplicates of their extra.install / extra.customCA / extra.karpenter counterparts. The fork is justified (the Mintlify versions use <Steps>, <Warning>, <Note> components and different heading levels, so they can't be shared verbatim), and you've documented it in the file header. The residual risk is that edits to, say, the multi-environment install YAML example in one place won't propagate to the other. Worth keeping in mind, but no action needed now — the body.* extraction already captured the parts that could be shared cleanly.
Summary
No bugs, no broken references, consistent with the existing helm-docs conventions. LGTM. ✅
· 20260706_split_helm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split Helm Mintlify docs pages into subpages to make it more readable.