Fix options flow not cleaning up entities on remote deselection - #16
Merged
Merged
Conversation
When a remote was removed from the watched list via the options flow, its button/number entities and subdevice devices were left behind because the re-scan only looked at remotes still in the new list. Add _cleanup_remote_entities() to remove all entities and empty devices for deselected remotes before re-scanning. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_cleanup_remote_entities()that removes all entities and empty devices for deselected remotes before re-scanningtest_options_update_cleans_up_deselected_remoteverifying the fixTest plan
python -m pytest tests/ -x -q— 57 tests passruff check && ruff format --check— clean🤖 Generated with Claude Code