Skip to content

ci: drop Go version from unit test job names - #9

Merged
kolkov merged 1 commit into
mainfrom
ci/unit-test-job-names
Oct 17, 2026
Merged

kolkov merged 1 commit into
mainfrom
ci/unit-test-job-names

Conversation

@kolkov

@kolkov kolkov commented Oct 17, 2026

Copy link
Copy Markdown
Owner

The unit test job name included the Go version (Unit Tests - ubuntu-latest - Go 1.25). Required status checks match jobs by name, so every Go version bump renamed the checks, and PRs waited for checks that would never report.

The job is now Unit Tests - <os>. The matrix still sets the Go version; only the display name changes. The branch ruleset for main already requires the new names, and this PR reports them.

actionlint v1.7.7 reports no issues for test.yml.

Required status checks match jobs by name. With the Go version in the
name, every toolchain bump renamed the checks and left PRs waiting for
checks that never report. The matrix still sets the Go version.
@github-actions

Copy link
Copy Markdown

Benchmark Comparison

Comparing main → PR #9

Summary: geomean 695.5n 694.0n -0.21%

⚠️ Potential regressions detected:

geomean            31.49         31.49        +0.00%
geomean            5.180         5.180        +0.00%
ParallelExecutor_Filter_Large-4         36.16Mi ± ∞ ¹   36.16Mi ± ∞ ¹  +0.00% (p=0.032 n=5)
geomean                                             ³                  +0.00%               ³
ParallelExecutor_Filter_Large-4          1.000M ± ∞ ¹   1.000M ± ∞ ¹  +0.00% (p=0.048 n=5)
geomean                                             ³                 +0.03%               ³

Full results available in workflow artifacts. CI runners have ~10-20% variance.
For accurate benchmarks, run locally: bash scripts/pre-release-check.sh

@codecov

codecov Bot commented Oct 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.60%. Comparing base (97c7d56) to head (8f5310c).

❌ Your project check has failed because the head coverage (63.60%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   63.60%   63.60%           
=======================================
  Files          32       32           
  Lines        8820     8820           
=======================================
  Hits         5610     5610           
  Misses       2878     2878           
  Partials      332      332           
Flag Coverage Δ
unittests 63.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97c7d56...8f5310c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kolkov
kolkov merged commit e367b20 into main Oct 17, 2026
12 of 13 checks passed
@kolkov
kolkov deleted the ci/unit-test-job-names branch October 17, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant