fix(actionqueue): guard cancel nil in StopCleanup - #2687
Open
directionless wants to merge 1 commit into
Open
directionless wants to merge 1 commit into
directionless wants to merge 1 commit into
Conversation
directionless
marked this pull request as ready for review
April 12, 2026 02:29
Comment on lines
+178
to
181
| if aq.cancel != nil { | ||
| aq.cancel() | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
We probably also want a lock around aq.cancel to avoid flaky data race failures in tests?
Contributor
Author
There was a problem hiding this comment.
It passed CI, do you still think we need it?
Contributor
There was a problem hiding this comment.
Yes, might as well if we're updating this area anyway
directionless
force-pushed
the
claude/fix-actionqueue-cancel-nil
branch
from
April 13, 2026 18:58
7a8c6b4 to
43b6fbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cancel is only set when StartCleanup is called. If StopCleanup is called first (e.g. during failed startup), cancel is nil and panics.