Skip to content

Adding check for request.POST (django >=1.9) cf. request.REQUEST (django <= 1.8) - #60

Closed
jamonation wants to merge 3 commits into
klen:developfrom
jamonation:develop
Closed

jamonation wants to merge 3 commits into
klen:developfrom
jamonation:develop

Conversation

@jamonation

Copy link
Copy Markdown

Here's a little conditional that will handle older django versions and recent 1.9 and newer when calling preview on a markdown field.

@jamonation

Copy link
Copy Markdown
Author

Hey @klen or @yavorskiy - do you need anything else to get this merged into master? I made sure travis will build, and this is working for those of using Django 1.9.x.

For reference, it looks like coverage 4.x doesn't need the [report] section for django_mardown given the size of the project, since it will report on anything in [run] by default. So I removed that section and everything looks good.

Would either of you mind reviewing this PR?

Cheers!

@iLikeKoffee

Copy link
Copy Markdown

@jamonation Awesome fix! Hope that will be merged! Thank you!

@jgruhl

jgruhl commented Mar 12, 2016

Copy link
Copy Markdown

@klen are you still able to support this? I'd be willing to support at least the PR's that address the django 1.9 updates.

@ajoyoommen

Copy link
Copy Markdown

This PR needs to be merged.

@jamonation jamonation closed this by deleting the head repository Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants