Repository navigation
Adding check for request.POST (django >=1.9) cf. request.REQUEST (django <= 1.8) - #60
Closed
jamonation wants to merge 3 commits into
Closed
jamonation wants to merge 3 commits into
jamonation wants to merge 3 commits into
Conversation
Author
|
Hey @klen or @yavorskiy - do you need anything else to get this merged into master? I made sure travis will build, and this is working for those of using Django 1.9.x. For reference, it looks like coverage 4.x doesn't need the Would either of you mind reviewing this PR? Cheers! |
|
@jamonation Awesome fix! Hope that will be merged! Thank you! |
|
@klen are you still able to support this? I'd be willing to support at least the PR's that address the django 1.9 updates. |
|
This PR needs to be merged. |
ajoyoommen
approved these changes
Oct 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a little conditional that will handle older django versions and recent 1.9 and newer when calling preview on a markdown field.