Update python-for-android prerequisites (Dockerfile, prerequisites.py, docs)#2923
Merged
misl6 merged 5 commits intokivy:developfrom Nov 20, 2023
Merged
Update python-for-android prerequisites (Dockerfile, prerequisites.py, docs)#2923misl6 merged 5 commits intokivy:developfrom
python-for-android prerequisites (Dockerfile, prerequisites.py, docs)#2923misl6 merged 5 commits intokivy:developfrom
Conversation
misl6
force-pushed
the
fix/use-jdk-17
branch
2 times, most recently
from
9cd9856 to
89eba7f
Compare
misl6
force-pushed
the
fix/use-jdk-17
branch
from
89eba7f to
413d95c
Compare
misl6
force-pushed
the
fix/use-jdk-17
branch
from
7438542 to
99f8773
Compare
misl6
changed the title
python-for-android prerequisites (in Dockerfile, docs, CI)python-for-android prerequisites (Dockerfile, prerequisites.py, docs)
Member
Author
|
Hi @Julian-O , |
AndreMiras
approved these changes
Nov 20, 2023
Contributor
|
Should we be mentioning:
Other than that, looks good. [Reminder: I think we should be testing on an instance of this Docker, too.] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile(clean up of old requirements and change of base image)17as a prerequisite, newer JDK versions such as21are incompatible with our version ofgradle, andgradlenow requires at leastJDK 17