Skip to content

android_api to integer #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
misl6 merged 3 commits into from
Mar 12, 2023
Merged

android_api to integer #2765

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21d929c
android_api to integer
kuzeyron Mar 6, 2023
534ff7a
changes to android_api
kuzeyron Mar 12, 2023
10f07e7
changes to android_api
kuzeyron Mar 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions pythonforandroid/bootstraps/common/build/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,15 +497,9 @@ def make_package(args):
# Find the SDK directory and target API
with open('project.properties', 'r') as fileh:
target = fileh.read().strip()
android_api = target.split('-')[1]
try:
int(android_api)
except (ValueError, TypeError):
raise ValueError(
"failed to extract the Android API level from " +
"build.properties. expected int, got: '" +
str(android_api) + "'"
)
Comment on lines -504 to -508
Copy link
Copy Markdown
Member

@misl6 misl6 Mar 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but maybe we can keep the error message?

aapi = target.split('-')[1]
android_api = int(aapi) if aapi.isdigit() else -1

with open('local.properties', 'r') as fileh:
sdk_dir = fileh.read().strip()
sdk_dir = sdk_dir[8:]
Expand Down