Add debug loggings for identifying a matching dist#2751
Merged
AndreMiras merged 2 commits intokivy:developfrom Feb 17, 2023
BitcoinWukong:wukong--debug-possible-dists
Merged
Add debug loggings for identifying a matching dist#2751AndreMiras merged 2 commits intokivy:developfrom BitcoinWukong:wukong--debug-possible-dists
AndreMiras merged 2 commits intokivy:developfrom
BitcoinWukong:wukong--debug-possible-dists
Conversation
AndreMiras
previously approved these changes
Feb 16, 2023
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Yes why not, thanks for the context.
Let's see if the CI is happy about it
pythonforandroid/distribution.py
Outdated
Comment on lines
+143
to
+149
| debug(f"Skipping dist due to forced build") | ||
| continue | ||
| if ndk_api is not None and dist.ndk_api != ndk_api: | ||
| debug(f"Skipping dist due to ndk_api mismatch") | ||
| continue | ||
| if not all(arch_name in dist.archs for arch_name in archs): | ||
| debug(f"Skipping dist due to arch mismatch") |
Member
There was a problem hiding this comment.
Minor: linter may complain about that f-string
AndreMiras
approved these changes
Feb 17, 2023
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM, let's see if the CI is all good before merging
misl6
added a commit
that referenced
this pull request
May 22, 2023
* Add support for Python 3.10 and make it the default while building hostpython3 and python3 (#2577) * Add support for Python 3.10 and make it the default while building hostpython3 and python3 * Update bugfix version * Add PyAV recipe (#2750) * pyav recipe * flake8 fix * Update pythonforandroid/recipes/av/__init__.py Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com> --------- Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com> * Add debug loggings for identifying a matching dist (#2751) * Add debug loggings for identifying a matching dist * Fix lint failure on f-string. * Adds flag to support home app (launcher) intent-filter on SDL2 bootstrap (#2761) * Home app functionality * Cleanup * Added --home-app to the docs * Fixed the if statements within the intent-filter * Use io.IOBase for LogFile (#2763) This provides reasonable default implementations for common IO class methods such as isatty(). Closes #2762. * android_api to integer (#2765) * android_api to integer * changes to android_api * changes to android_api * fix #2768 smallIconName null can t be compared to String (#2769) * fix #2768 smallIconName null can t be compared to String * fix: Remove Importance None of notification which is modification from my own fork * fix: Readd Importance_NONE in the notification channel as it s also in upstream p4a * fix tools/liblink: syntax error regression from 22b7dfe * Update pyjnius version in recipe (#2791) * Update Kivy recipe for 2.2.0 (#2793) * Update Kivy recipe for 2.2.0rc1 * Bump to 2.2.0 * Update CHANGELOG.md and bump version to 2023.05.21 --------- Co-authored-by: Dexer <73297572+DexerBR@users.noreply.github.com> Co-authored-by: Andre Miras <AndreMiras@users.noreply.github.com> Co-authored-by: BitcoinWukong <87334822+BitcoinWukong@users.noreply.github.com> Co-authored-by: Mathias Lindström <kuzeyron@gmail.com> Co-authored-by: Dylan McCall <dylan@dylanmccall.ca> Co-authored-by: Benoît HERVIER <b@rvier.fr> Co-authored-by: SomberNight <somber.night@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes the android dist is being rebuilt every time, and it's hard to understand why that happens. This PR adds some debug logging so that it's easier to investigate when this happens.
In my case, I incorrectly used
CythonandPillowin therequirementsof mybuildozer.spec, and this caused my dist to be rebuild every time, becausedist.recipeswould havecythonandpillowin it, and p4a thinks it's missing the recipesCythonandPillow.