Made recipe graph resolution respect opt_depends#1617
Merged
inclement merged 1 commit intokivy:masterfrom Jan 27, 2019
Merged
Conversation
AndreMiras
approved these changes
Jan 27, 2019
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM!
It should be feasible to write a test case by mocking Recipe.get_recipe() and having some dummy recipe that demo the case
This was referenced Jan 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the recipe ordering issue reported in #1590 and elsewhere.
I wanted to add a test case for this but couldn't actually find an input to the graph that resulted in an invalid ordering unless opt_depends were respected. The reason is that openssl and sqlite3 both have no dependencies, so the graph is already guaranteed (I think) to schedule them to be built before python3.
Nevertheless, opt_depends support was definitely broken and this should fix it. It must have been broken for a very long time, since I replaced the graph resolution. I guess complex opt_depends requirements don't come up that often.