Repository navigation
feat(web): draw the tyre gauge as the kart from behind - #358
Merged
Merged
Conversation
The gauge now shows the own kart as the chase camera sees it: rear wing across the top, the two rear tyres toned by the wear band, the driver's hair inside the halo. kartFromAbove is retired; its tyre block stays as tyreBlock. The style guide shows the gauge in all three bands. Closes #352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Instrument panel's tyre gauge now draws the own kart from behind, as the chase camera sees it, instead of from above (ADR 0105, take 3 of
docs/mockups/coin-and-tyre-gauge-variations.html).data-tyre-corner, so they take the band's tone. Tyre life is one number, so hiding the fronts loses nothing.data-tyre-wearare unchanged. The gauge SVG widens from--hud * 3.6to4.2, as in the mockup.docs/style-guide.htmlnow draws the kart from behind and shows the gauge in all three bands. The from-above rule andtyre lifeindocs/GLOSSARY.mdnow say "from behind".Evidence
data-tyre-cornertyres around a kart seen from above.After: the panel was staged headless at tyre life 100, 45 and 12 for liveries 1, 4 and 6. Bands read good/warn/bad, both rears filled green/yellow/red, and each livery's hair colour was drawn.
pnpm test: 1195 passed. Biome and typecheck are clean.Screenshots:
Merge Danger
Door: two-way
A drawing swap. Reverting the commit restores the kart from above.
Blast Radius: cosmetic
Only the tyre gauge icon and its width in the speed cluster change. The gauge is 0.6
--hudwider, which nudges the BOX, STOP and RAIN plates that sit off the cluster's right edge.Closes #352