Shop room: refresh the vendored widget from Chronicle - #161
Merged
Merged
Conversation
Chronicle's shop room widget gained a slide-out arrange panel that waits for Save room. Foundry never turns on arrange mode, so nothing changes on screen here; the copy is refreshed so it stays identical to Chronicle. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JRAx4Ex5fEHkxVB5Yaqw86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: none (keeps
vendor/chronicle/identical to Chronicle after keyxmakerx/Chronicle#1057)Security implication: none. This is a client-side widget copy only. Buying and the socket relay are untouched.
Consumer-verified: n/a
Mockup: n/a. Nothing changes on screen in Foundry: the new panel exists only in arrange mode, and the module never turns arrange mode on.
What this changes
Before: the module's copy of Chronicle's shop room widget was older than Chronicle main.
After:
vendor/chronicle/shop_room.jsis byte-identical to Chronicle main, which now includes #1057's slide-out arrange panel.In Foundry the room looks and works the same as before. The module never sets
data-can-arrange, so the Arrange button and panel don't render. The new outside-click listener returns straight away unless arrange mode is on, and the widget's own cleanup removes it.How
vendor/chronicle/shop_room.js: copied unchanged from Chronicle main.shop_room_icons.jswas already identical.Test plan
CHRONICLE_DIR=../Chronicle node --test tools/test-*.mjswith Chronicle at current main (2896bd1): 1417 pass, 0 fail. The run includestools/test-shop-room.mjs, which checks that the copy is identical to Chronicle's.Tenet self-check